New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create tree-shakeable `Msgpack` module #1375

Closed

owenpearson opened this issue Jul 5, 2023 · 1 comment

Assignees

Member

owenpearson commented Jul 5, 2023

depends on Create tree-shakeable BaseClient and Rest modules #1374
create a class called Msgpack which can be passed to the BaseClient constructor
if and only if the Msgpack module is not supplied, BaseClient will use json encoding for all requests and the msgpack dependency will not be imported

The text was updated successfully, but these errors were encountered:

sync-by-unito bot commented Jul 5, 2023

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-3718

lawrence-forooghian added a commit that referenced this issue


          Add a _MsgPack property to BaseClient

19b7117

The _MsgPack assignment becomes the only place that
Platform.Config.msgpack gets accessed. All other uses now instead access
_MsgPack.

Preparation for #1375 (making MessagePack functionality tree-shakable).

sync-by-unito bot assigned lawrence-forooghian

lawrence-forooghian added a commit that referenced this issue


          Move MsgPack interface into its own file

9c39d09

Preparation for #1375 (making MessagePack functionality tree-shakable).

lawrence-forooghian added a commit that referenced this issue


          Add a _MsgPack property to BaseClient

352b826

The _MsgPack assignment becomes the only place that
Platform.Config.msgpack gets accessed. All other uses now instead access
_MsgPack.

Preparation for #1375 (making MessagePack functionality tree-shakable).

lawrence-forooghian added a commit that referenced this issue


          Make MessagePack functionality tree-shakable

618bfe2

We move the MessagePack functionality into a tree-shakable MsgPack
module.

Resolves #1375.

lawrence-forooghian added a commit that referenced this issue


          Move MsgPack interface into its own file

affbf2d

Preparation for #1375 (making MessagePack functionality tree-shakable).

lawrence-forooghian added a commit that referenced this issue


          Add a _MsgPack property to BaseClient

30bd86b

The _MsgPack assignment becomes the only place that
Platform.Config.msgpack gets accessed. All other uses now instead access
_MsgPack.

Preparation for #1375 (making MessagePack functionality tree-shakable).

lawrence-forooghian added a commit that referenced this issue


          Make BaseClient._MsgPack nullable

598642f

This is preparation for #1375 (making MessagePack functionality
tree-shakable), in which there may not be a MessagePack implementation
available.

We update normaliseClientOptions so that it only sets useBinaryProtocol
to true if there is a MessagePack implementation available.

lawrence-forooghian added a commit that referenced this issue


          Make MessagePack functionality tree-shakable

5514a00

We move the MessagePack functionality into a tree-shakable MsgPack
module.

Resolves #1375.

lawrence-forooghian mentioned this issue

Web build does not use MessagePack by default #1424

Closed

lawrence-forooghian added a commit that referenced this issue


          Make BaseClient._MsgPack nullable

afff1c8

This is preparation for #1375 (making MessagePack functionality
tree-shakable), in which there may not be a MessagePack implementation
available.

We update normaliseClientOptions so that it only sets useBinaryProtocol
to true if there is a MessagePack implementation available.

lawrence-forooghian added a commit that referenced this issue


          Make MessagePack functionality tree-shakable

1dd7667

We move the MessagePack functionality into a tree-shakable MsgPack
module.

Resolves #1375.

lawrence-forooghian added a commit that referenced this issue


          Make MessagePack functionality tree-shakable

f320e0a

We move the MessagePack functionality into a tree-shakable MsgPack
module.

Resolves #1375.

lawrence-forooghian mentioned this issue

[SDK-3718] Create tree-shakable MsgPack module #1425

Merged

lawrence-forooghian added a commit that referenced this issue


          Move MsgPack interface into its own file

4f4b0a8

Preparation for #1375 (making MessagePack functionality tree-shakable).

lawrence-forooghian added a commit that referenced this issue


          Add a _MsgPack property to BaseClient

d057ea8

The _MsgPack assignment becomes the only place that
Platform.Config.msgpack gets accessed. All other uses now instead access
_MsgPack.

Preparation for #1375 (making MessagePack functionality tree-shakable).

lawrence-forooghian added a commit that referenced this issue


          Make BaseClient._MsgPack nullable

54f1842

This is preparation for #1375 (making MessagePack functionality
tree-shakable), in which there may not be a MessagePack implementation
available.

We update normaliseClientOptions so that it only sets useBinaryProtocol
to true if there is a MessagePack implementation available.

lawrence-forooghian added a commit that referenced this issue


          Make MessagePack functionality tree-shakable

46aa0c9

We move the MessagePack functionality into a tree-shakable MsgPack
module.

Resolves #1375.

lawrence-forooghian added a commit that referenced this issue


          Make BaseClient._MsgPack nullable

151ae5c

This is preparation for #1375 (making MessagePack functionality
tree-shakable), in which there may not be a MessagePack implementation
available.

We update normaliseClientOptions so that it only sets useBinaryProtocol
to true if there is a MessagePack implementation available.

lawrence-forooghian added a commit that referenced this issue


          Make MessagePack functionality tree-shakable

dee1c19

We move the MessagePack functionality into a tree-shakable MsgPack
module.

Resolves #1375.

lawrence-forooghian added a commit that referenced this issue


          Make MessagePack functionality tree-shakable

We move the MessagePack functionality into a tree-shakable MsgPack
module.

Resolves #1375.

lawrence-forooghian added a commit that referenced this issue

wip

b4a1c01

TODO test
TODO remove static PresenceMessage property

Resolves #1375.

lawrence-forooghian added a commit that referenced this issue


          Make realtime presence functionality tree-shakable

64cf416

We move it into a tree-shakable RealtimePresence module.

Resolves #1375.

lawrence-forooghian added a commit that referenced this issue


          Make realtime presence functionality tree-shakable

1931f45

We move it into a tree-shakable RealtimePresence module.

Resolves #1375.

lawrence-forooghian mentioned this issue

[SDK-3732] Make realtime presence functionality tree-shakable #1428

Merged

lawrence-forooghian added a commit that referenced this issue


          Make realtime presence functionality tree-shakable

73c9b5f

We move it into a tree-shakable RealtimePresence module.

Resolves #1375.

lawrence-forooghian added a commit that referenced this issue


          Make MessagePack functionality tree-shakable

3a4867d

We move the MessagePack functionality into a tree-shakable MsgPack
module.

Resolves #1375.

lawrence-forooghian added a commit that referenced this issue


          Make realtime presence functionality tree-shakable

39fa2cd

We move it into a tree-shakable RealtimePresence module.

Resolves #1375.

lawrence-forooghian added a commit that referenced this issue


          Move MsgPack interface into its own file

0649ddd

Preparation for #1375 (making MessagePack functionality tree-shakable).

lawrence-forooghian added a commit that referenced this issue


          Add a _MsgPack property to BaseClient

a2d00ef

The _MsgPack assignment becomes the only place that
Platform.Config.msgpack gets accessed. All other uses now instead access
_MsgPack.

Preparation for #1375 (making MessagePack functionality tree-shakable).

lawrence-forooghian added a commit that referenced this issue


          Make MessagePack functionality tree-shakable

7fc3a75

We move the MessagePack functionality into a tree-shakable MsgPack
module.

Resolves #1375.

lawrence-forooghian added a commit that referenced this issue


          Make realtime presence functionality tree-shakable

d364b86

We move it into a tree-shakable RealtimePresence module.

Resolves #1375.

lawrence-forooghian added a commit that referenced this issue


          Move MsgPack interface into its own file

6c305a1

Preparation for #1375 (making MessagePack functionality tree-shakable).

lawrence-forooghian added a commit that referenced this issue


          Add a _MsgPack property to BaseClient

913637a

The _MsgPack assignment becomes the only place that
Platform.Config.msgpack gets accessed. All other uses now instead access
_MsgPack.

Preparation for #1375 (making MessagePack functionality tree-shakable).

lawrence-forooghian added a commit that referenced this issue


          Make MessagePack functionality tree-shakable

3998cdc

We move the MessagePack functionality into a tree-shakable MsgPack
module.

Resolves #1375.

lawrence-forooghian added a commit that referenced this issue


          Make realtime presence functionality tree-shakable

674c059

We move it into a tree-shakable RealtimePresence module.

Resolves #1375.

lawrence-forooghian added a commit that referenced this issue


          Move MsgPack interface into its own file

93d7a67

Preparation for #1375 (making MessagePack functionality tree-shakable).

lawrence-forooghian added a commit that referenced this issue


          Add a _MsgPack property to BaseClient

0d21a81

The _MsgPack assignment becomes the only place that
Platform.Config.msgpack gets accessed. All other uses now instead access
_MsgPack.

Preparation for #1375 (making MessagePack functionality tree-shakable).

lawrence-forooghian added a commit that referenced this issue


          Make MessagePack functionality tree-shakable

9efcf0c

We move the MessagePack functionality into a tree-shakable MsgPack
module.

Resolves #1375.

lawrence-forooghian added a commit that referenced this issue


          Make realtime presence functionality tree-shakable

78f0a35

We move it into a tree-shakable RealtimePresence module.

Resolves #1375.

lawrence-forooghian added a commit that referenced this issue


          Move MsgPack interface into its own file

2a887b6

Preparation for #1375 (making MessagePack functionality tree-shakable).

lawrence-forooghian added a commit that referenced this issue


          Add a _MsgPack property to BaseClient

6d36786

The _MsgPack assignment becomes the only place that
Platform.Config.msgpack gets accessed. All other uses now instead access
_MsgPack.

Preparation for #1375 (making MessagePack functionality tree-shakable).

lawrence-forooghian added a commit that referenced this issue


          Make MessagePack functionality tree-shakable

badeeb7

We move the MessagePack functionality into a tree-shakable MsgPack
module.

Resolves #1375.

lawrence-forooghian added a commit that referenced this issue


          Make realtime presence functionality tree-shakable

c80ea79

We move it into a tree-shakable RealtimePresence module.

Resolves #1375.

lawrence-forooghian added a commit that referenced this issue


          Move MsgPack interface into its own file

ae1c4de

Preparation for #1375 (making MessagePack functionality tree-shakable).

lawrence-forooghian added a commit that referenced this issue


          Add a _MsgPack property to BaseClient

5230f05

The _MsgPack assignment becomes the only place that
Platform.Config.msgpack gets accessed. All other uses now instead access
_MsgPack.

Preparation for #1375 (making MessagePack functionality tree-shakable).

lawrence-forooghian added a commit that referenced this issue


          Make MessagePack functionality tree-shakable

f2e425a

We move the MessagePack functionality into a tree-shakable MsgPack
module.

Resolves #1375.

lawrence-forooghian added a commit that referenced this issue


          Make realtime presence functionality tree-shakable

d0a9d7c

We move it into a tree-shakable RealtimePresence module.

Resolves #1375.

sync-by-unito bot closed this as completed

lawrence-forooghian added a commit that referenced this issue


          Make realtime presence functionality tree-shakable

7cbd6fc

We move it into a tree-shakable RealtimePresence module.

Resolves #1375.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment