ConnectionManager: Fix uprade bug that could lead to an indefinitely sync-pending transport #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
staging/pull/1041/bundle-report
…sync-pending transport If we start an upgrade, but then the previous active transport disconnects by the time the upgrade transport connects, we just want to activate it immediately. But the previous logic was sending you down the activateTransport path in that case, and the problem with that is that the library only sends a sync() message to the server in the scheduleTransportActivation path. So the server is left waiting for a sync that will never come, and stays in upgrade-pending limbo. Fixed by just using the scheduleTransportActivation path, which can cope fine with the lack of an active protocol (though made a small tweak to that logic too)
SimonWoolf
force-pushed
the
fix-missing-sync
branch
from
03469a0
to
9cec75d
Compare
owenpearson
approved these changes
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we start an upgrade, but then the previous active transport disconnects by the time the upgrade transport connects, we just want to activate it immediately. But the previous logic was sending you down the activateTransport path in that case, and the problem with that is that the library only sends a sync() message to the server in the scheduleTransportActivation path. So the server is left waiting for a sync that will never come, and stays in upgrade-pending limbo.
Fixed by just using the scheduleTransportActivation path, which can cope fine with the lack of an active protocol (though made a small tweak to that logic too).