Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConnectionManager: Fix uprade bug that could lead to an indefinitely sync-pending transport #1041

Merged
merged 1 commit into from
Aug 8, 2022

Commits on Aug 8, 2022

  1. ConnectionManager: Fix uprade bug that could lead to an indefinitely …

    …sync-pending transport
    
    If we start an upgrade, but then the previous active transport
    disconnects by the time the upgrade transport connects, we just want to
    activate it immediately. But the previous logic was sending you down the
    activateTransport path in that case, and the problem with that is that
    the library only sends a sync() message to the server in the
    scheduleTransportActivation path. So the server is left waiting for a
    sync that will never come, and stays in upgrade-pending limbo.
    
    Fixed by just using the scheduleTransportActivation path, which can cope
    fine with the lack of an active protocol (though made a small tweak to
    that logic too)
    SimonWoolf committed Aug 8, 2022
    Configuration menu
    Copy the full SHA
    9cec75d View commit details
    Browse the repository at this point in the history