Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests no force ws; fix failure to callback on presence event causing implicit attach #127

Merged
merged 6 commits into from
Sep 14, 2015

Conversation

SimonWoolf
Copy link
Member

Started out as a PR to just stop forcing web_sockets when not necessary (fixes #127), ended up also fixing a couple bugs that that exposed:

  • If there's an error in an implicit attach caused by sending a presence message, callback with that err. (was only a problem with presence not with normal messages since normal messages get their callback called in RealtimeChannel#failPendingMessages). + test (and another test for normal messages, though that one was already passing)
  • Fixed an onNack callback typo in protocol.js. (indicator that codepath for NACKs is not well-tested?)

paddybyers added a commit that referenced this pull request Sep 14, 2015
Tests no force ws; fix failure to callback on presence event causing implicit attach
@paddybyers paddybyers merged commit 343b2d9 into new-upgrade Sep 14, 2015
@paddybyers
Copy link
Member

Thanks

@SimonWoolf SimonWoolf deleted the tests-no-force-ws branch October 6, 2015 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants