Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests no force ws; fix failure to callback on presence event causing implicit attach #127

Merged
merged 6 commits into from
Sep 14, 2015
Merged

Tests no force ws; fix failure to callback on presence event causing implicit attach #127

merged 6 commits into from
Sep 14, 2015

Commits on Sep 12, 2015

  1. Don't force websockets in presence & crypto tests

    @SimonWoolf
    SimonWoolf committed Sep 12, 2015
    Configuration menu
    Copy the full SHA
    c331b90 View commit details
    Browse the repository at this point in the history

  2. If error when attaching b/c presence msg, callback with error

    @SimonWoolf
    SimonWoolf committed Sep 12, 2015
    Configuration menu
    Copy the full SHA
    06e5cef View commit details
    Browse the repository at this point in the history

  3. Fix onNack typo in protocol.js

    @SimonWoolf
    SimonWoolf committed Sep 12, 2015
    Configuration menu
    Copy the full SHA
    bc5cbfc View commit details
    Browse the repository at this point in the history

  4. Add test for presence implicit attach with invalid channel name

    @SimonWoolf
    SimonWoolf committed Sep 12, 2015
    Configuration menu
    Copy the full SHA
    fa66803 View commit details
    Browse the repository at this point in the history

  5. Add test for msg implicit attach w/ valid and invalid channel names

    @SimonWoolf
    SimonWoolf committed Sep 12, 2015
    Configuration menu
    Copy the full SHA
    030f915 View commit details
    Browse the repository at this point in the history

  6. Fix failure test in node 

    Ably.Realtime.ConnectionManager not defined in node
    @SimonWoolf
    SimonWoolf committed Sep 12, 2015
    Configuration menu
    Copy the full SHA
    22a8a8d View commit details
    Browse the repository at this point in the history