Various new-upgrade and test fixes #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not just plain objects
To: - not have any shared connection state between tests - not rely on having a thee-second timeout at the end of each test - not use the same channel in every test - be a bit DRYer among other changes
saucelabs is slow when running things concurrently
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| define(function(require) { | |||
| var environment = isBrowser ? (window.__env__ || {}) : process.env, | |||
| ablyEnvironment = environment.ABLY_ENV || 'sandbox', | |||
| ablyEnvironment = environment.ABLY_ENV || 'staging', | |||
There was a problem hiding this comment.
We shouldn't commit this change.
|
A couple of comments but otherwise LGTM. |
SimonWoolf
force-pushed
the
upgrade-test-fixes
branch
from
e86e597
to
e6c2362
Compare
paddybyers
added a commit
that referenced
this pull request
Sep 22, 2015
Various new-upgrade and test fixes
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly test fixes. Biggest change is a big overhaul of the presence tests, which were previously failing randomly in hard-to-debug ways. Only significant non-test changes are bcdf532 and e6c2362 .
Still not passing in ci, but last two failures have been a realtime bug causing dup messages (https://github.com/ably/realtime/issues/297), so raising the PR.