-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various new-upgrade and test fixes #131
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
7a9d902
Upgrade test: allow comet messages through so upgrade handshake can c…
SimonWoolf 7fedbaf
Spec helper for simulating dropped connections
SimonWoolf bcdf532
Make comet transports emit actual ProtocolMessages
SimonWoolf a4af948
Fix enter7 test: second presence message can come through as an update
SimonWoolf 2b2d8e9
Fix enter3 test: give valid failure branch same no. of expectations a…
SimonWoolf 433dba4
Rewrite the realtime presence tests to be less fragile
SimonWoolf cd1a826
Upgrade tests: fix tests using the same channel name
SimonWoolf 72ecdb6
Event emitter test: don’t bother reclosing a closed connection
SimonWoolf 0461ad1
Spec helper: activeProtocol may be undefined or null
SimonWoolf b72cbca
Connection events test: shortcircuit on IE
SimonWoolf 97d0ec9
Connection events test: restore old timeout defaults when done
SimonWoolf d99456e
More generous limits in connection test
SimonWoolf 09d48b9
Stats tests: request up to an hour ago to filter out data from fixtures
SimonWoolf e6c2362
Add ConnectionManager#abort (used by RealtimeChannel#onMessage)
SimonWoolf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry to be picky but we've used
/* ... */
comment style throughout.