Change Crypto.generateRandomKey API to use Promises
#1351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
staging/pull/1351/bundle-report
lawrence-forooghian
force-pushed
the
1345-change-generateRandomKey-to-promise
branch
from
2cd2757
to
4161a9f
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1351/bundle-report
lawrence-forooghian
force-pushed
the
1213-update-tests-to-use-promise-api
branch
from
49c4d92
to
d0f034e
Compare
lawrence-forooghian
force-pushed
the
1345-change-generateRandomKey-to-promise
branch
from
4161a9f
to
a0105eb
Compare
owenpearson
approved these changes
Jul 3, 2023
Base automatically changed from
1213-update-tests-to-use-promise-api
to
integration/v2
July 3, 2023 12:04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This is based on top of #1349; please review that one first.
This adds the missing Promise-based version of this method.
Since we’re going to be removing the callbacks API in #1199 anyway, I’ve just replaced the callbacks version of the method.
Resolves #1345. SDK-3682