[SDK-3548] Remove public callbacks API #1358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
staging/pull/1358/bundle-report
lawrence-forooghian
force-pushed
the
1199-remove-callbacks-api
branch
from
255a509
to
69d9bee
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1358/bundle-report
lawrence-forooghian
force-pushed
the
1199-remove-callbacks-api
branch
from
69d9bee
to
03b7d76
Compare
lawrence-forooghian
changed the base branch from
1345-change-generateRandomKey-to-promise
to
integration/v2
lawrence-forooghian
force-pushed
the
1199-remove-callbacks-api
branch
from
03b7d76
to
1a5b2df
Compare
lawrence-forooghian
force-pushed
the
1199-remove-callbacks-api
branch
from
1a5b2df
to
9b9a746
Compare
lawrence-forooghian
changed the base branch from
integration/v2
to
1345-change-generateRandomKey-to-promise
lawrence-forooghian
force-pushed
the
1199-remove-callbacks-api
branch
from
9b9a746
to
3ce5194
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1358/bundle-report
lawrence-forooghian
changed the title
Base automatically changed from
1345-change-generateRandomKey-to-promise
to
integration/v2
July 3, 2023 12:05
owenpearson
requested changes
Jul 3, 2023
I’m not sure what purpose this was serving — Promise can just be accessed as a global variable.
In version 2.0 of the library we’re assuming Promise is always available.
We’ve decided that in version 2 of the SDK, we’ll only offer a promise-based API. Note that this doesn’t change the use of callbacks internally in the SDK; that’s a separate thing we might wish to do in the future. Resolves #1199.
No longer needed now that, as of 2a2ed49, the promises API is the only one we offer.
Motivation as in 693804c.
…lBase Preparation for merging the *Base and *Promise classes.
I want to merge the following classes together: - RestBase and RestPromise into a class named Rest - RealtimeBase and RealtimePromise into a class named Realtime However, I need to decide what to do about the inheritance of RealtimeBase from RestBase. The obvious thing to do would be to make Realtime inherit from Rest, but this won’t work because RealtimeChannel’s type declaration does not include a `status()` function and hence Realtime.channels cannot satisfy the type of Rest.channels. So, since the IDL does not mention any inheritance relation between the REST and Realtime classes, I’m going to sever this connection in the type declarations. (We can consider the fact that _internally_ there is inheritance to be an implementation detail.)
The *Base classes are no longer needed now that we’ve removed the *Callbacks classes.
lawrence-forooghian
force-pushed
the
1199-remove-callbacks-api
branch
from
3ce5194
to
6cb7179
Compare
owenpearson
approved these changes
Jul 3, 2023
hayleynewton
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR is based on top of #1351; please review that one first.
This removes the callback-based variant of the public API. See commit messages for more details.
Resolves #1199.