[SDK-3910] Fix RealtimePresence#leave handling of PresenceMessage argument
#1466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RealtimePresence’s `enter*`, `update*` and `leave*` methods all advertise themselves as accepting a PresenceMessage instance instead of just a data object. This is the only way that ably-js supports passing message extras to these methods. However, `leave` does not handle a PresenceMessage argument properly; it ends up nesting the PresenceMessage’s top-level fields inside the payload’s `data` property. To fix this, we change the argument handling to match that used by `enter`. Resolves #1465.
lawrence-forooghian
changed the title
RealtimePresence#leave handling of PresenceMessage argument
lawrence-forooghian
deleted the
1465-presence-leave-handle-presence-message
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RealtimePresence’senter*,update*andleave*methods all advertise themselves as accepting aPresenceMessageinstance instead of just a data object. This is the only way that ably-js supports passing message extras to these methods.However,
leavedoes not handle aPresenceMessageargument properly; it ends up nesting thePresenceMessage’s top-level fields inside the payload’sdataproperty.To fix this, we change the argument handling to match that used by
enter.Resolves #1465.