Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-3910] Fix RealtimePresence#leave handling of PresenceMessage argument #1466

Merged

Commits on Oct 20, 2023

  1. Fix RealtimePresence#leave handling of PresenceMessage argument

    RealtimePresence’s `enter*`, `update*` and `leave*` methods all
    advertise themselves as accepting a PresenceMessage instance instead of
    just a data object. This is the only way that ably-js supports passing
    message extras to these methods.
    
    However, `leave` does not handle a PresenceMessage argument properly; it
    ends up nesting the PresenceMessage’s top-level fields inside the
    payload’s `data` property.
    
    To fix this, we change the argument handling to match that used by
    `enter`.
    
    Resolves #1465.
    lawrence-forooghian committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    dfe425c View commit details
    Browse the repository at this point in the history