Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miscellaneous tweaks to transport handling and auth tests #296

Closed
wants to merge 8 commits into from
Closed

Miscellaneous tweaks to transport handling and auth tests #296

wants to merge 8 commits into from

Commits on Jun 27, 2016

  1. Revert publishVariations change from apply to direct fn call

    @SimonWoolf
    SimonWoolf committed Jun 27, 2016
    Configuration menu
    Copy the full SHA
    2081939 View commit details
    Browse the repository at this point in the history

  2. Tweak auth_token_expires test for resilience against very slow crespo… 

    …nses
    @SimonWoolf
    SimonWoolf committed Jun 27, 2016
    Configuration menu
    Copy the full SHA
    4c388a2 View commit details
    Browse the repository at this point in the history

  3. Upgrade: stop preference timeout unconditionally on tryConnect cb 

    The original idea behind not stopping it was in case something stalled
the websocket between 'viable' and 'connected' stages, so that the
fallback would be used then. In practice we have no evidence that that's
ever happened (an established websocket generally means we can use the
websocket transport), and keeping the timeout running causes problems if
the connection is successful but then something else disconnects it just
before the timeout expires (eg a quick token expiry).
    @SimonWoolf
    SimonWoolf committed Jun 27, 2016
    Configuration menu
    Copy the full SHA
    c643c0b View commit details
    Browse the repository at this point in the history

  4. Remove transport from proposedTransports on deactivation

    @SimonWoolf
    SimonWoolf committed Jun 27, 2016
    Configuration menu
    Copy the full SHA
    3782b4e View commit details
    Browse the repository at this point in the history

  5. Use safeArrForEach for when the function might mutate the array 

    Previously, only every other transport in eg the pendingTransports array
was getting disconnected by disconnectAllTransports, as each
disconnection (in deactivateTransport) was mutating pendingTransports to
remove itself. This would be ok if the removal used `delete`, but it
(meaning Utils.arrDeleteValue) used slice, which renumbers as it goes,
so array iteration gets messed up.
    @SimonWoolf
    SimonWoolf committed Jun 27, 2016
    Configuration menu
    Copy the full SHA
    68a106f View commit details
    Browse the repository at this point in the history

  6. Rewrite reauth_authcallback test to check capability, not ttl 

    So it doesn't fail if the token takes too long to get, and/or take ages
to give it enough buffer not to do the other thing
    @SimonWoolf
    SimonWoolf committed Jun 27, 2016
    Configuration menu
    Copy the full SHA
    7173dda View commit details
    Browse the repository at this point in the history

  7. Exclude json where possible 

    Why? Because you can't abort requests. (You can remove the node, but
that doesn't cancel the request). So recv requests stick around for 90s till
realtime ends them. So in a test, the browsers max-connections-per-host
limit fills up quickly, which messes up other comet transports too
    @SimonWoolf
    SimonWoolf committed Jun 27, 2016
    Configuration menu
    Copy the full SHA
    ca9ab91 View commit details
    Browse the repository at this point in the history

  8. TEMP NOTFORMERGING use staging rather than sandbox for ci 

    While sandbox is unstable, to avoid spurious failures
    @SimonWoolf
    SimonWoolf committed Jun 27, 2016
    Configuration menu
    Copy the full SHA
    496d268 View commit details
    Browse the repository at this point in the history