-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Miscellaneous tweaks to transport handling and auth tests #296
Closed
Closed
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
2081939
Revert publishVariations change from apply to direct fn call
SimonWoolf 4c388a2
Tweak auth_token_expires test for resilience against very slow crespo…
SimonWoolf c643c0b
Upgrade: stop preference timeout unconditionally on tryConnect cb
SimonWoolf 3782b4e
Remove transport from proposedTransports on deactivation
SimonWoolf 68a106f
Use safeArrForEach for when the function might mutate the array
SimonWoolf 7173dda
Rewrite reauth_authcallback test to check capability, not ttl
SimonWoolf ca9ab91
Exclude json where possible
SimonWoolf 496d268
TEMP NOTFORMERGING use staging rather than sandbox for ci
SimonWoolf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -90,7 +90,15 @@ define(['spec/common/modules/testapp_module', 'spec/common/modules/client_module | |
|
||
/* testFn is assumed to be a function of realtimeOptions that returns a nodeunit test */ | ||
function testOnAllTransports(exports, name, testFn, excludeUpgrade) { | ||
utils.arrForEach(availableTransports, function(transport) { | ||
/* Don't include jsonp if possible. Why? Because you can't abort requests. So recv's | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. So when will jsonp get tested? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In |
||
* stick around for 90s till realtime ends them. So in a test, the | ||
* browsers max-connections-per-host limit fills up quickly, which messes | ||
* up other comet transports too */ | ||
var transports = utils.arrIn(availableTransports, 'xhr_polling') ? | ||
utils.arrWithoutValue(availableTransports, 'jsonp') : | ||
availableTransports; | ||
|
||
utils.arrForEach(transports, function(transport) { | ||
exports[name + '_with_' + transport + '_binary_transport'] = testFn({transports: [transport], useBinaryProtocol: true}); | ||
exports[name + '_with_' + transport + '_text_transport'] = testFn({transports: [transport], useBinaryProtocol: false}); | ||
}); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really want to commit this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, was just to change the ci run. (Hence the commit message of
TEMP NOTFORMERGING
:) )