Sync robustness fixes #302
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it's a failure before the sync has actually started, can just do abandon() and continue on the old transport, which we can't do for actual sync failures. Also regularise the connection state check, was missing an edge-case (connecting)
…ransports If there's been some problem with syncing, we have a problem -- we can't just fall back on the old transport, as we don't know whether realtime got the sync -- if it did, the old transport is no longer valid. To be safe, we disconnect both and start again from scratch.
|
Re: 9c5295a in realtime we have an Otherwise LGTM. |
|
Awesome 👍 |
good idea, but should probably convert all one-off timers at once rather than just this one -- added a refactoring issue #306 |
SimonWoolf
added a commit
that referenced
this pull request
Jul 6, 2016
|
Merged as 8a3ff82 |
This was referenced Jul 7, 2016
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #300 . Will expand that ticket and do prs for lib version qs and trans pref tomorrow.