Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync robustness fixes #302

Closed
wants to merge 5 commits into from
Closed

Sync robustness fixes #302

wants to merge 5 commits into from

Commits on Jul 6, 2016

  1. Move transport.isConnected pre-sync check outside sync() 

    As it's a failure before the sync has actually started, can just do
abandon() and continue on the old transport, which we can't do for
actual sync failures.

Also regularise the connection state check, was missing an edge-case
(connecting)
    @SimonWoolf
    SimonWoolf committed Jul 6, 2016
    Configuration menu
    Copy the full SHA
    313333b View commit details
    Browse the repository at this point in the history

  2. Add a timeout to the upgrade sync()

    @SimonWoolf
    SimonWoolf committed Jul 6, 2016
    Configuration menu
    Copy the full SHA
    9c5295a View commit details
    Browse the repository at this point in the history

  3. If upgrade sync fails, we’re in an unknown state, so disconnect the t… 

    …ransports

If there's been some problem with syncing, we have a problem -- we
can't just fall back on the old transport, as we don't know whether
realtime got the sync -- if it did, the old transport is no longer
valid. To be safe, we disconnect both and start again from scratch.
    @SimonWoolf
    SimonWoolf committed Jul 6, 2016
    Configuration menu
    Copy the full SHA
    38751d5 View commit details
    Browse the repository at this point in the history

  4. ConnectionManager: retryImmediately if go from synchronizing to disco… 

    …nnected
    @SimonWoolf
    SimonWoolf committed Jul 6, 2016
    Configuration menu
    Copy the full SHA
    5fbffae View commit details
    Browse the repository at this point in the history

  5. Add test to check that upgrade sync failure doesn’t stall forever

    @SimonWoolf
    SimonWoolf committed Jul 6, 2016
    Configuration menu
    Copy the full SHA
    4ec1976 View commit details
    Browse the repository at this point in the history