Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve copyright summary #1043

Closed
pombredanne opened this issue Apr 24, 2018 · 2 comments
Closed

Improve copyright summary #1043

pombredanne opened this issue Apr 24, 2018 · 2 comments
Labels
bug copyright scan

Comments

@pombredanne
Copy link
Contributor

pombredanne commented Apr 24, 2018 •
edited
Loading

The new "--copyrights-summary" option has a few issues:

  1. It should be --copyright-summary singular
  2. the occurrences count for each copyrights should be retained: this is a better way to determine what is the primary copyright/copyright holder. Today every copyright holder is considered as "equal" even though some may be more prominent than others

This is an implementation for #377 and part of #930
pombredanne added a commit that referenced this issue May 7, 2018
@pombredanne
Add count to copyright summary #1043 #377
87ca90e 
 * also rename CLI option
 * add tests


Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
pombredanne added a commit that referenced this issue May 7, 2018
@pombredanne
Do not require the copyright option #1043 #377
42d83e1 
 * this way this can run from a virtual codebase too

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne pombredanne mentioned this issue May 23, 2018
Closed
pombredanne added a commit that referenced this issue Jun 7, 2018
@pombredanne
Add count to copyright summary #1043 #377
4eaace7 
 * also rename CLI option
 * add tests


Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
pombredanne added a commit that referenced this issue Jun 8, 2018
@pombredanne
Add count to copyright summary #1043 #377
ae1aa61 
 * also rename CLI option
 * add tests


Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
pombredanne added a commit that referenced this issue Jun 11, 2018
@pombredanne
Add count to copyright summary #1043 #377
109cb5c 
 * also rename CLI option
 * add tests


Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
pombredanne added a commit that referenced this issue Jun 11, 2018
@pombredanne
Use copyrights-summary everywhere, plural #1043
4a66de6 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
pombredanne added a commit that referenced this issue Jun 18, 2018
@pombredanne
Use one list for copyrights, holders, authors
dc3ae49 
NB: this is a breaking API change

* Each has their own list of items returned for #255
* for now holders are no longer expanded (e.g. this reverts the #182
  implementation available before). This will be reintriduced later as
  a CLI option as it is not possible to get great results for now
* the summary has been improved for #1043 and provides a much better
  holder summary. More refinements needed
* Some spurrious bare SPDX id have been removed to avoid FP #1114



Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Copy link
Contributor Author

Per #1107 we also need authors

pombredanne added a commit that referenced this issue Jun 22, 2018
@pombredanne
Add authors summaries #1043 #1107
1e75cec 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
pombredanne added a commit that referenced this issue Jul 16, 2018
@pombredanne
Improve summary computation #377 #1043
f40700d 
 * Fix test failures (from unstable sort order)
 * Refactor common code where relevant
 * Other minor refinements

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne pombredanne mentioned this issue Jul 16, 2018
Merged
@pombredanne
Copy link
Contributor Author

This has been merged in develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug copyright scan
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pombredanne