Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not mix multiple copyrights and authors in the returned data #255

Closed
jdaguil opened this issue Apr 28, 2016 · 1 comment
Closed

Do not mix multiple copyrights and authors in the returned data #255

jdaguil opened this issue Apr 28, 2016 · 1 comment
Assignees
@pombredanne
Labels
bug copyright scan must have new and improved data
Milestone
v3.0

Comments

@jdaguil
Copy link
Contributor

jdaguil commented Apr 28, 2016

Today, a copyright scan returns multiple statements, multiple holders, and authors. Mixing these together is not clear, and is not consistent with how we return other clues (i.e. emails, urls).
@pombredanne pombredanne modified the milestone: v2.0 Aug 5, 2016
@pombredanne pombredanne modified the milestones: v2.0, v2.1 Mar 24, 2017
@pombredanne pombredanne removed this from the v2.1 milestone Oct 4, 2017
@pombredanne pombredanne added this to the v3.0 milestone Oct 20, 2017
@pombredanne pombredanne mentioned this issue Feb 14, 2018
Closed
pombredanne added a commit that referenced this issue Jun 11, 2018
@pombredanne
Streamline copyright detection #930
7e8f56b 
* remove the returning of solo years: this is not used anywhere
* optionally exclude year from returned copyright
* handle some corner cases found in license texts
* add new function for future reorg of returned data structure for #255
  for now, not yet used as functions detect_copyrights2() and
  CopyrightDetector.detect2()


Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
pombredanne added a commit that referenced this issue Jun 11, 2018
@pombredanne
Streamline copyright detection #930
d3f9a93 
* remove the returning of solo years: this is not used anywhere
* optionally exclude year from returned copyright
* handle some corner cases found in license texts
* add new function for future reorg of returned data structure for #255
  for now, not yet used as functions detect_copyrights2() and
  CopyrightDetector.detect2()


Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne pombredanne mentioned this issue Jun 16, 2018
Closed
pombredanne added a commit that referenced this issue Jun 18, 2018
@pombredanne
Use one list for copyrights, holders, authors
dc3ae49 
NB: this is a breaking API change

* Each has their own list of items returned for #255
* for now holders are no longer expanded (e.g. this reverts the #182
  implementation available before). This will be reintriduced later as
  a CLI option as it is not possible to get great results for now
* the summary has been improved for #1043 and provides a much better
  holder summary. More refinements needed
* Some spurrious bare SPDX id have been removed to avoid FP #1114



Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Copy link
Contributor

Done and merged in develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pombredanne pombredanne

Labels
bug copyright scan must have new and improved data
Projects
None yet
Milestone
v3.0
Development

No branches or pull requests
2 participants
@pombredanne @jdaguil