Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support newer versions of python #54

Closed
cco3 opened this issue Nov 17, 2020 · 5 comments
Closed

Support newer versions of python #54

cco3 opened this issue Nov 17, 2020 · 5 comments
Assignees
@tdruez
Milestone
1.1

Comments

@cco3
Copy link

cco3 commented Nov 17, 2020

Is there a reason python3.6 is specifically required? On some Debian environments, it is impossible to use -m venv without the newest version of python.
@pombredanne
Copy link
Member

@cco3 3.6 is the base version were we test and that we support for now here and in all dependent libs... there is no hard requirement on it though, and we should enable CI and test runs on all version from 3.6 to 3.9 alright (and also first on all supporting libraries too)

@tdruez
Copy link
Contributor

tdruez commented Nov 18, 2020

The main reason for 3.6 is the dependency on ScanCode-toolkit https://scancode-toolkit.readthedocs.io/en/latest/getting-started/install.html#prerequisites
If the toolkit supports Python up to 3.9, this should be easy to enable 3.6 to 3.9 support in ScanCode.io
I'll start a branch to run the tests on 3.6+ versions.

tdruez added a commit that referenced this issue Nov 18, 2020
@tdruez
Enable Python 3.6 to 3.9 in travis CI configuration #54
86eca98 
Signed-off-by: Thomas Druez <tdruez@nexb.com>
tdruez added a commit that referenced this issue Nov 18, 2020
@tdruez
Remove the problematic typing library before install dev deps #54
80d6272 
Signed-off-by: Thomas Druez <tdruez@nexb.com>
tdruez added a commit that referenced this issue Nov 18, 2020
@tdruez
Add the ability to specified the PYTHON_EXE in Makefile #54
782fd32 
Signed-off-by: Thomas Druez <tdruez@nexb.com>
tdruez added a commit that referenced this issue Nov 18, 2020
@tdruez
Attempt to fix the 3.9 build #54
ba93efb 
Signed-off-by: Thomas Druez <tdruez@nexb.com>
tdruez added a commit that referenced this issue Nov 18, 2020
@tdruez
Add CHANGELOG entry and update documentation #54
951686f 
Signed-off-by: Thomas Druez <tdruez@nexb.com>
tdruez added a commit that referenced this issue Nov 18, 2020
@tdruez
Attempt #2 to make the travis script 3.x compatible #54
cb6321a 
Signed-off-by: Thomas Druez <tdruez@nexb.com>
tdruez added a commit that referenced this issue Nov 18, 2020
@tdruez
Attempt #3 to make the travis script 3.x compatible #54
0681ca5 
Signed-off-by: Thomas Druez <tdruez@nexb.com>
tdruez added a commit that referenced this issue Nov 18, 2020
@tdruez
Attempt #4 to make the travis script 3.x compatible #54
3a4eb40 
Signed-off-by: Thomas Druez <tdruez@nexb.com>
tdruez added a commit that referenced this issue Nov 18, 2020
@tdruez
Attempt #5 to make the travis script 3.x compatible #54
2b10c4f 
Signed-off-by: Thomas Druez <tdruez@nexb.com>
tdruez added a commit that referenced this issue Nov 18, 2020
@tdruez
Attempt #6 to make the travis script 3.x compatible #54
fff67ff 
Signed-off-by: Thomas Druez <tdruez@nexb.com>
tdruez added a commit that referenced this issue Nov 18, 2020
@tdruez
Remove debugging line in Makefile #54
1f4f0be 
Signed-off-by: Thomas Druez <tdruez@nexb.com>
@tdruez
Copy link
Contributor

tdruez commented Nov 18, 2020 •
edited
Loading

Support for 3.6 to 3.9 is going fairly well.

There's only 1 blocker: the scancode-toolkit dependency on typing as typing is now part of the standard library since Python 3.5 and installing the backport is a source of issues on Python3.7+

See python/typing#573 and python/typing#573 (comment) for the solution.

The local workaround is to uninstall typing right after installing the scancode-toolkit.
@pombredanne Could we implement a proper fix on the toolkit side?

Edit: The PR is already merged aboutcode-org/commoncode#5 :)

tdruez added a commit that referenced this issue Nov 18, 2020
@tdruez
Use sys.executable instead of bin/python for pipeline method #54
69f376c 
Signed-off-by: Thomas Druez <tdruez@nexb.com>
tdruez added a commit that referenced this issue Nov 18, 2020
@tdruez
Support for Python 3.6 to 3.9 #54
78688a8 
* Enable Python 3.6 to 3.9 in travis CI configuration #54
* Remove the problematic typing library before install dev deps #54
* Add the ability to specified the PYTHON_EXE in Makefile #54
* Add CHANGELOG entry and update documentation #54
* Use sys.executable instead of bin/python for pipeline method #54

Signed-off-by: Thomas Druez <tdruez@nexb.com>
@tdruez
Copy link
Contributor

tdruez commented Nov 18, 2020

Support for Python 3.6 to 3.9 merged in main branch.
Keeping the ticket open to remove the workaround at https://github.com/nexB/scancode.io/blob/main/Makefile#L52 once the new version of the toolkit and commoncode are available.

@tdruez tdruez added this to the 1.1 milestone Nov 18, 2020
@tdruez tdruez self-assigned this Nov 18, 2020
tdruez added a commit that referenced this issue Jan 19, 2021
@tdruez
Temporary revert to previous commoncode version until new scancode-to…
b68ee5a 
…olkit is released #54

Signed-off-by: Thomas Druez <tdruez@nexb.com>
tdruez added a commit that referenced this issue Feb 11, 2021
@tdruez
Upgrade ScanCode-toolkit to latest 21.2.9 version #54
434f7f9
@tdruez
Copy link
Contributor

tdruez commented Feb 11, 2021

Support for Python 3.6 to 3.9 now officially supported with the new ScanCode-toolkit 21.2.9 version.

@tdruez tdruez closed this as completed Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tdruez tdruez

Labels
None yet
Projects
None yet
Milestone
1.1
Development

No branches or pull requests
3 participants
@cco3 @tdruez @pombredanne