-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fail to import typing while running test which runs process which imports typing from setup.py with pytest in python 3.7 #573
Comments
You don't need to install the backport on 3.7, because typing is in the standard library since 3.5. I suspect you need a requirement like |
@JelleZijlstra, that would work, thanks. It would be nice if this worked using this backport anyway, if this backport is installed by a package not under my control. Also, if it is not suggested for people to install this backport under newer versions of python, should there be a warning on installation of this package with newer versions of python? |
…thon3.7) (#1638) * typing is part of standard library from python3.6 installing it on python3.7 causes AttributeError: type object 'Callable' has no attribute '_abc_registry' refers #1457 and python/typing/issues/573 * remove typing backport because is part of python3.6 natively and allennlp requires python3.6
…thon3.7) (allenai#1638) * typing is part of standard library from python3.6 installing it on python3.7 causes AttributeError: type object 'Callable' has no attribute '_abc_registry' refers allenai#1457 and python/typing/issues/573 * remove typing backport because is part of python3.6 natively and allennlp requires python3.6
No need to backport python/typing#573 (comment)
No need to backport python/typing#573 (comment)
It's part of the standard library starting from 3.5. See python/typing#573.
Installing `typing` on recent Python versions leads to the error described in python/typing#573 (running tests with tox yields `AttributeError: type object 'Callable' has no attribute '_abc_registry'`). The [`typing` readme](https://pypi.org/project/typing/) suggests to install the package only for Python versions <3.5, which this commit does.
Importing typing causes errors after python 3.6. See python/typing#573
Importing typing causes errors after python 3.6. See python/typing#573 Signed-off-by: Conley Owens <cco3@google.com>
Importing typing causes errors after python 3.6. See python/typing#573 Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
All supported Python versions now include the |
This is related to python/typing#573: `typing` is now part of the Python standard library. Adding `typing` as dependency to modules will lead to the installation a second, incompatible versions of that module.
setup.py
test_test.py
I've used docker, to make this error more reproducible but this errors outside docker as well
The text was updated successfully, but these errors were encountered: