Dump importer_yielder in favor of IMPORTER_REGISTRY and drop Etags #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hritik14
force-pushed
the
migration/importer_yielder
branch
from
457c91f
to
4a24a14
Compare
Hritik14
force-pushed
the
migration/importer_yielder
branch
from
4a24a14
to
7175362
Compare
pombredanne
requested changes
Jan 27, 2022
Hritik14
force-pushed
the
migration/importer_yielder
branch
5 times, most recently
from
89cdfee
to
058b9a8
Compare
IMPORTER_REGISTRY is neater and does not do any magical string -> object conversion. The registry looks more in sync with improvers. Fixes: aboutcode-org#501 Signed-off-by: Hritik Vijay <hritikxx8@gmail.com>
Etags are meant for transient usage in browsers and are not meant for any long term usage. Fixes: aboutcode-org#321 Signed-off-by: Hritik Vijay <hritikxx8@gmail.com>
Signed-off-by: Hritik Vijay <hritikxx8@gmail.com>
Hritik14
force-pushed
the
migration/importer_yielder
branch
from
058b9a8
to
0c4905e
Compare
The name DataSource and Importer were majorly used interchangeably although they represent the same concept. Also, the importers now require a mandatory ``spdx_license_expression`` to run Signed-off-by: Hritik Vijay <hritikxx8@gmail.com>
Signed-off-by: Hritik Vijay <hritikxx8@gmail.com>
Same for improvers IMPROVER_REGISTRY -> IMPROVERS_REGISTRY Signed-off-by: Hritik Vijay <hritikxx8@gmail.com>
Signed-off-by: Hritik Vijay <hritikxx8@gmail.com>
We can use @classmethod and @Property together in python 3.9. Not so in 3.8 Signed-off-by: Hritik Vijay <hritikxx8@gmail.com>
Hritik14
force-pushed
the
migration/importer_yielder
branch
from
0c4905e
to
c62f81f
Compare
pombredanne
requested changes
Feb 7, 2022
|
|
||
| # TODO: Needs rewrite |
There was a problem hiding this comment.
May be an issue to track may work better?
There was a problem hiding this comment.
This will be a part of #597
|
|
||
|
|
||
| def test_ImportRunner_existing_package_and_new_vulnerability(db): |
There was a problem hiding this comment.
Could this test be kept somehow? to valid that we never will allow twice the same set of imported data?
There was a problem hiding this comment.
| assert vuln_refs[0].url == "https://example.com/with/more/info/CVE-2020-13371337" | ||
|
|
||
|
|
||
| def test_ImportRunner_new_package_version_affected_by_existing_vulnerability(db): |
There was a problem hiding this comment.
IMHO this may be need to be kept
| assert impacted_package.vulnerability.vulnerability_id == "CVE-2020-13371337" | ||
|
|
||
|
|
||
| # def test_ImportRunner_fixed_package_version_is_added(db): |
There was a problem hiding this comment.
Could this test have been of value? and need to be kept?
| # assert resolved_package.vulnerability.vulnerability_id == "CVE-2020-13371337" | ||
|
|
||
|
|
||
| def test_ImportRunner_updated_vulnerability(db): |
There was a problem hiding this comment.
IMHO this may be need to be kept, moved to improvers?
There was a problem hiding this comment.
All of these will be moved to improvers. Importers cannot test relationships. It will be a part of a new PR. Tracked in: #612
Signed-off-by: Hritik Vijay <hritikxx8@gmail.com> Co-authored-by: Philippe Ombredanne <pombredanne@gmail.com>
Hritik14
force-pushed
the
migration/importer_yielder
branch
from
61023e6
to
45cdaf5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name
DataSourceandImporterare majorly used interchangeably. This needs to be fixed in a different PR.