Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dump importer_yielder in favor of IMPORTER_REGISTRY and drop Etags #600

Merged
merged 10 commits into from
Feb 7, 2022

Commits on Feb 5, 2022

  1. Dump importer_yielder in favor of IMPORTER_REGISTRY

    IMPORTER_REGISTRY is neater and does not do any magical string -> object
    conversion. The registry looks more in sync with improvers.
    Fixes: aboutcode-org#501
    
    Signed-off-by: Hritik Vijay <hritikxx8@gmail.com>
    Hritik14 committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    7c3d7a8 View commit details
    Browse the repository at this point in the history
  2. Remove etags

    Etags are meant for transient usage in browsers and are not meant for
    any long term usage.
    Fixes: aboutcode-org#321
    
    Signed-off-by: Hritik Vijay <hritikxx8@gmail.com>
    Hritik14 committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    12c842e View commit details
    Browse the repository at this point in the history
  3. Refactor importer/improver registry

    Signed-off-by: Hritik Vijay <hritikxx8@gmail.com>
    Hritik14 committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    744259b View commit details
    Browse the repository at this point in the history
  4. Bulk rename DataSource -> Importer

    The name DataSource and Importer were majorly used interchangeably
    although they represent the same concept.
    Also, the importers now require a mandatory ``spdx_license_expression``
    to run
    
    Signed-off-by: Hritik Vijay <hritikxx8@gmail.com>
    Hritik14 committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    f7f843a View commit details
    Browse the repository at this point in the history
  5. Add dummy license to nginx importer

    Signed-off-by: Hritik Vijay <hritikxx8@gmail.com>
    Hritik14 committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    cf836e2 View commit details
    Browse the repository at this point in the history
  6. IMPORTER_REGISTRY -> IMPORTERS_REGISTRY

    Same for improvers
    IMPROVER_REGISTRY -> IMPROVERS_REGISTRY
    
    Signed-off-by: Hritik Vijay <hritikxx8@gmail.com>
    Hritik14 committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    5dc1281 View commit details
    Browse the repository at this point in the history
  7. Improve documentation/text

    Signed-off-by: Hritik Vijay <hritikxx8@gmail.com>
    Hritik14 committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    b1f204a View commit details
    Browse the repository at this point in the history
  8. Add tests

    Tests for:
    	* manage.py import command
    	* manage.py improve command
    	* import_runner
    
    Signed-off-by: Hritik Vijay <hritikxx8@gmail.com>
    Hritik14 committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    d7bc7b4 View commit details
    Browse the repository at this point in the history
  9. Use custom classproperty for python 3.8 compatibility

    We can use @classmethod and @Property together in python 3.9. Not so in
    3.8
    
    Signed-off-by: Hritik Vijay <hritikxx8@gmail.com>
    Hritik14 committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    c62f81f View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2022

  1. Resolve a few final nits

    Signed-off-by: Hritik Vijay <hritikxx8@gmail.com>
    Co-authored-by: Philippe Ombredanne <pombredanne@gmail.com>
    Hritik14 and pombredanne committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    45cdaf5 View commit details
    Browse the repository at this point in the history