Change normalisation of ordered-imports

This makes it consistent with TypeScript's Organize Imports command Fixes palantir#4063
aboyton · Nov 7, 2018 · fa78d7c · fa78d7c
1 parent 191f5e4
commit fa78d7c
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/src/rules/orderedImportsRule.ts b/src/rules/orderedImportsRule.ts
@@ -24,7 +24,6 @@ import {
     isStringLiteral,
 } from "tsutils";
 import * as ts from "typescript";
-
 import * as Lint from "../index";
 
 export class Rule extends Lint.Rules.AbstractRule {
@@ -135,7 +134,7 @@ export class Rule extends Lint.Rules.AbstractRule {
 type Transform = (x: string) => string;
 const TRANSFORMS = new Map<string, Transform>([
     ["any", () => ""],
-    ["case-insensitive", x => x.toLowerCase()],
+    ["case-insensitive", x => x.toUpperCase()],
     ["lowercase-first", flipCase],
     ["lowercase-last", x => x],
     ["full", x => x],

diff --git a/test/rules/ordered-imports/case-insensitive/test.ts.fix b/test/rules/ordered-imports/case-insensitive/test.ts.fix
@@ -6,6 +6,10 @@ import {A, B} from 'foo'; // failure
 import {A, bz, C} from 'foo'; // failure
 import {A, b, C} from 'zfoo';
 
+// Underscores come last.
+import {A, C, _b} from 'zfoo'; // failure
+import {A, C, _b} from 'zfoo';
+
 import {g} from "y"; // failure
 import {
     a as d,

diff --git a/test/rules/ordered-imports/case-insensitive/test.ts.lint b/test/rules/ordered-imports/case-insensitive/test.ts.lint
@@ -9,6 +9,11 @@ import {bz, A, C} from 'foo'; // failure
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~            [Import sources within a group must be alphabetized.]
         ~~~~~                            [Named imports must be alphabetized.]
 
+// Underscores come last.
+import {A, _b, C} from 'zfoo'; // failure
+           ~~~~~              [Named imports must be alphabetized.]
+import {A, C, _b} from 'zfoo';
+
 import {
     b as c,
     ~~~~~~~