-
Notifications
You must be signed in to change notification settings - Fork 887
ordered-imports rule doesn't sort in the same order as Organize Imports in TypeScript #4063
Comments
This makes it consistent with TypeScript's Organize Imports command Fixes palantir#4063
This makes it consistent with TypeScript's Organize Imports command Fixes palantir#4063
This makes it consistent with TypeScript's Organize Imports command Fixes palantir#4063
Is there a reason this isn't being picked up? This is a feature I (and I'm guessing many others) have been waiting for for a long time. |
@Timebutt it's marked as |
I know and I'm looking to contribute, was just wondering if there might be a specific reason why this wouldn't be fixed? Implementing this will be a breaking change, forcing everybody to change code and this might not be desired. If there is nothing preventing us from fixing this, I will try my hand at implementing this for sure! |
Gotcha, great!
Good call - adding the missing label. We can review a PR and hold off merging it until the next major version, which should be soon. |
We have a PR for it, it's #4064. I'd love to see this merged although personally I just forked months ago. |
So we actually have the fix, and it was just waiting for a next major version? In that case, it seems like the timing is in our favour, as a new version will be around soon right @JoshuaKGoldberg? |
Correct! 🙌 |
Removing the |
Thx for the work ! Is the fix expected to ship in the next release ? |
Bug Report
See microsoft/TypeScript#25114
TypeScript code being linted
with
tslint.json
configuration:Actual behaviour
It sorts it to
import { _bar, foo }
, which is different to how TypeScript organises it.Expected behaviour
No lint error.
The difference seems to be that TypeScript is normalising strings using
toUpperCase
where astslint
usestoLowerCase
.The text was updated successfully, but these errors were encountered: