NOISSUE - Fix Postgres writer transaction handling #1335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com>
nmarcetic
approved these changes
Jan 21, 2021
drasko
reviewed
Jan 21, 2021
| @@ -51,7 +51,7 @@ func (pr postgresRepo) Consume(message interface{}) (err error) { | |||
| } | |||
| } | |||
|
|
|||
| func (pr postgresRepo) saveSenml(messages interface{}) error { | |||
| func (pr postgresRepo) saveSenml(messages interface{}) (err error) { | |||
There was a problem hiding this comment.
Why do we need this named param, when err is not used in the function?
There was a problem hiding this comment.
Because the deferred function is using err var. Before we named it, the deferred function was using the wrong error value - the one from the BeginTxx method, rather than the one returned from saveSenml.
mteodor
approved these changes
Jan 22, 2021
drasko
approved these changes
Jan 23, 2021
fbugarski
pushed a commit
to fbugarski/mainflux
that referenced
this pull request
Mar 8, 2021
Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: dusanb94 dusan.borovcanin@mainflux.com
What does this do?
This pull request fixes the Postgres writer transaction error handling bug discovered here.
Which issue(s) does this PR fix/relate to?
There is no such issue.
List any changes that modify/break current functionality
There are no such changes. This only fixes problem with handling the error in the deferred function.
Have you included tests for your changes?
No.
Did you document any new/modified functionality?
No.