Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NOISSUE - Fix Postgres writer transaction handling #1335

Merged
merged 1 commit into from
Jan 23, 2021
Merged

NOISSUE - Fix Postgres writer transaction handling #1335

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion consumers/writers/postgres/consumer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ func (pr postgresRepo) Consume(message interface{}) (err error) {
}
}

func (pr postgresRepo) saveSenml(messages interface{}) error {
func (pr postgresRepo) saveSenml(messages interface{}) (err error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this named param, when err is not used in the function?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the deferred function is using err var. Before we named it, the deferred function was using the wrong error value - the one from the BeginTxx method, rather than the one returned from saveSenml.

msgs, ok := messages.([]senml.Message)
if !ok {
return errSaveMessage
Expand Down