NOISSUE - Add Call Home Client to Mainflux services #1751

SammyOina · 2023-03-27T11:31:49Z

What does this do?

Ping mainflux home server with information regarding the deployment:

IP Address
Last seen
Service name
MF version

Which issue(s) does this PR fix/relate to?

None

List any changes that modify/break current functionality

None

Have you included tests for your changes?

No

Did you document any new/modified functionality?

No

Notes

codecov-commenter · 2023-03-27T11:41:29Z

Codecov Report

Merging #1751 (80d57df) into clients (241a61d) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           clients    #1751      +/-   ##
===========================================
- Coverage    65.58%   65.54%   -0.05%     
===========================================
  Files          116      116              
  Lines         9452     9452              
===========================================
- Hits          6199     6195       -4     
- Misses        2595     2597       +2     
- Partials       658      660       +2

Impacted Files	Coverage Δ
things/clients/service.go	`68.20% <ø> (ø)`

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

internal/homing/homing.go

http/README.md

lora/README.md

mqtt/README.md

opcua/README.md

drasko

LGTM

cmd/coap/main.go

drasko · 2023-04-27T22:42:41Z

cmd/http/main.go

@@ -82,6 +84,10 @@ func main() {
 	}
 	hs := httpserver.New(ctx, cancel, svcName, httpServerConfig, api.MakeHandler(svc, tracer, logger), logger)

+	homeSvc := client.New(svcName, cfg.MFRelease, logger, cancel)


There is repetition of these lines in every main(). Didn't @arvindh123 unify our main functions to avoid repetition?

mqtt/README.md

dborovcanin

We should not set MFRelease this way but during artifacts build. Please consult health.go and Makefile for more info. Also, please redirect this PR to the clients branch so we can sync easier for the 0.14 release.

dborovcanin

We need this for Things and Users, as well.

vendor/github.com/mainflux/callhome/pkg/client/client.go

cmd/coap/main.go

vendor/github.com/mainflux/callhome/pkg/client/client.go

http/README.md

Signed-off-by: SammyOina <sammyoina@gmail.com>

* Move Things and Users to Clients Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com> Signed-off-by: rodneyosodo <blackd0t@protonmail.com> Signed-off-by: SammyOina <sammyoina@gmail.com> * collect and send data package Signed-off-by: SammyOina <sammyoina@gmail.com> * create telemetry migrations Signed-off-by: SammyOina <sammyoina@gmail.com> * add telemetry endpoints Signed-off-by: SammyOina <sammyoina@gmail.com> * add transport Signed-off-by: SammyOina <sammyoina@gmail.com> * create service Signed-off-by: SammyOina <sammyoina@gmail.com> * remove homing server Signed-off-by: SammyOina <sammyoina@gmail.com> * add call home to adapters Signed-off-by: SammyOina <sammyoina@gmail.com> * add last seen Signed-off-by: SammyOina <sammyoina@gmail.com> * rename logger Signed-off-by: SammyOina <sammyoina@gmail.com> * remove homing client Signed-off-by: SammyOina <sammyoina@gmail.com> * use unmerged repo Signed-off-by: SammyOina <sammyoina@gmail.com> * use renamed module Signed-off-by: SammyOina <sammyoina@gmail.com> * update call home version Signed-off-by: SammyOina <sammyoina@gmail.com> * edit documentation Signed-off-by: SammyOina <sammyoina@gmail.com> * align table Signed-off-by: SammyOina <sammyoina@gmail.com> * use alias for call home client Signed-off-by: SammyOina <sammyoina@gmail.com> * update callhome Signed-off-by: SammyOina <sammyoina@gmail.com> * update call home pkg Signed-off-by: SammyOina <sammyoina@gmail.com> * update call home Signed-off-by: SammyOina <sammyoina@gmail.com> * fix modules Signed-off-by: SammyOina <sammyoina@gmail.com> * use mf build version Signed-off-by: SammyOina <sammyoina@gmail.com> * use mf build version Signed-off-by: SammyOina <sammyoina@gmail.com> * restore default Signed-off-by: SammyOina <sammyoina@gmail.com> * add call home for users and things Signed-off-by: SammyOina <sammyoina@gmail.com> * enable opting on call home Signed-off-by: SammyOina <sammyoina@gmail.com> * remove full stops Signed-off-by: SammyOina <sammyoina@gmail.com> * update callhome client Signed-off-by: SammyOina <sammyoina@gmail.com> * add call home to all services Signed-off-by: SammyOina <sammyoina@gmail.com> * fix build Signed-off-by: SammyOina <sammyoina@gmail.com> * restore sdk tests Signed-off-by: SammyOina <sammyoina@gmail.com> * remove unnecessary changes Signed-off-by: SammyOina <sammyoina@gmail.com> * restore health_test.go Signed-off-by: SammyOina <sammyoina@gmail.com> --------- Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com> Signed-off-by: rodneyosodo <blackd0t@protonmail.com> Signed-off-by: SammyOina <sammyoina@gmail.com> Co-authored-by: b1ackd0t <blackd0t@protonmail.com> Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com>

* Move Things and Users to Clients Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com> Signed-off-by: rodneyosodo <blackd0t@protonmail.com> Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com> * NOISSUE - Update Add and Delete Policies (#1792) * Remove Policy Action Ranks Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Rebase Issues Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix CI Test Errors Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Adding Check on Subject For Clients Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Remove Check Client Exists Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Check When Sharing Clients Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Only Add User to Group When Sharing Things Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Remove clientType Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Minor Fix on ShareClient and Fix Tests Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Policies Tests Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Clean Up Things Authorization Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Tests on RetrieveAll Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Test ShareThing Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Merge Conflicts Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Remove Adding Policies. Only Use Ownership Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Check If Subject is same as Object Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Move Back To Union As Sometimes Policy is Empty and Fails to Evaluate on Ownership Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Entity Type For Failing Tests Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix BUG in policy evaluation Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Tests Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Add Comments Regarding checkAdmin Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Tests On Rebase Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Combine Authorize For Things and Users Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Tests On Rebase Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Error on Things SVC `unsupported protocol scheme` Signed-off-by: rodneyosodo <blackd0t@protonmail.com> --------- Signed-off-by: rodneyosodo <blackd0t@protonmail.com> Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com> * Fix Bug on Things Authorization Cache (#1810) Signed-off-by: rodneyosodo <blackd0t@protonmail.com> Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com> * Use Password instead of username in MQTT handler Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com> * Simplify MQTT authorization Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com> * Fix MQTT tests Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com> * NOISSUE - Add More Functions to SDK (#1811) * Add More Functions to SDK Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Add Examples to GoDoc Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Update Unassign Interface Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Pass Subject as ID and Not Token on List Channels By Thing Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Bootstrap Errors For Element Check Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Add empty line Before Return Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Reorder URLS in things mux Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Listing Things Policies Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Share Thing Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Add Examples to CLI Docs Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Update Identity To Update Another User Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Identify an Update Policies on Things Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Update Things Policies Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix GoDocs on Disconnect Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Tests Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Change Authorize To Use AccessRequest Signed-off-by: rodneyosodo <blackd0t@protonmail.com> --------- Signed-off-by: rodneyosodo <blackd0t@protonmail.com> Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com> * For Evaluate Policy Use AccessRequest (#1814) Signed-off-by: rodneyosodo <blackd0t@protonmail.com> Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com> * NOISSUE - Add SDK Tests (#1812) * Add Things Tests Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Add Channel Tests Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Add Certs Tests Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Add Consumer Tests Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Enrich Group Tests Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Add Tests For Health Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Add Tests For Tokens Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Rename SDK for Tests Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Add Policies Tests Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Linter Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Tests Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Make Variable Defination Inline Signed-off-by: rodneyosodo <blackd0t@protonmail.com> --------- Signed-off-by: rodneyosodo <blackd0t@protonmail.com> Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com> * NOISSUE - Make Cache Key Duration Configurable (#1815) * Make Cache Key Duration Configurable Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Rename ENV Var Signed-off-by: rodneyosodo <blackd0t@protonmail.com> --------- Signed-off-by: rodneyosodo <blackd0t@protonmail.com> Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com> * NOISSUE - Update GoDocs (#1816) * Add GoDocs Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Add Missing GoDoc Files Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Enable godot Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Add License Information Signed-off-by: rodneyosodo <blackd0t@protonmail.com> --------- Signed-off-by: rodneyosodo <blackd0t@protonmail.com> Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com> * NOISSUE - Add Call Home Client to Mainflux services (#1751) * Move Things and Users to Clients Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com> Signed-off-by: rodneyosodo <blackd0t@protonmail.com> Signed-off-by: SammyOina <sammyoina@gmail.com> * collect and send data package Signed-off-by: SammyOina <sammyoina@gmail.com> * create telemetry migrations Signed-off-by: SammyOina <sammyoina@gmail.com> * add telemetry endpoints Signed-off-by: SammyOina <sammyoina@gmail.com> * add transport Signed-off-by: SammyOina <sammyoina@gmail.com> * create service Signed-off-by: SammyOina <sammyoina@gmail.com> * remove homing server Signed-off-by: SammyOina <sammyoina@gmail.com> * add call home to adapters Signed-off-by: SammyOina <sammyoina@gmail.com> * add last seen Signed-off-by: SammyOina <sammyoina@gmail.com> * rename logger Signed-off-by: SammyOina <sammyoina@gmail.com> * remove homing client Signed-off-by: SammyOina <sammyoina@gmail.com> * use unmerged repo Signed-off-by: SammyOina <sammyoina@gmail.com> * use renamed module Signed-off-by: SammyOina <sammyoina@gmail.com> * update call home version Signed-off-by: SammyOina <sammyoina@gmail.com> * edit documentation Signed-off-by: SammyOina <sammyoina@gmail.com> * align table Signed-off-by: SammyOina <sammyoina@gmail.com> * use alias for call home client Signed-off-by: SammyOina <sammyoina@gmail.com> * update callhome Signed-off-by: SammyOina <sammyoina@gmail.com> * update call home pkg Signed-off-by: SammyOina <sammyoina@gmail.com> * update call home Signed-off-by: SammyOina <sammyoina@gmail.com> * fix modules Signed-off-by: SammyOina <sammyoina@gmail.com> * use mf build version Signed-off-by: SammyOina <sammyoina@gmail.com> * use mf build version Signed-off-by: SammyOina <sammyoina@gmail.com> * restore default Signed-off-by: SammyOina <sammyoina@gmail.com> * add call home for users and things Signed-off-by: SammyOina <sammyoina@gmail.com> * enable opting on call home Signed-off-by: SammyOina <sammyoina@gmail.com> * remove full stops Signed-off-by: SammyOina <sammyoina@gmail.com> * update callhome client Signed-off-by: SammyOina <sammyoina@gmail.com> * add call home to all services Signed-off-by: SammyOina <sammyoina@gmail.com> * fix build Signed-off-by: SammyOina <sammyoina@gmail.com> * restore sdk tests Signed-off-by: SammyOina <sammyoina@gmail.com> * remove unnecessary changes Signed-off-by: SammyOina <sammyoina@gmail.com> * restore health_test.go Signed-off-by: SammyOina <sammyoina@gmail.com> --------- Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com> Signed-off-by: rodneyosodo <blackd0t@protonmail.com> Signed-off-by: SammyOina <sammyoina@gmail.com> Co-authored-by: b1ackd0t <blackd0t@protonmail.com> Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com> --------- Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com> Signed-off-by: rodneyosodo <blackd0t@protonmail.com> Signed-off-by: SammyOina <sammyoina@gmail.com> Co-authored-by: b1ackd0t <blackd0t@protonmail.com> Co-authored-by: Sammy Kerata Oina <44265300+SammyOina@users.noreply.github.com>

SammyOina requested a review from a team as a code owner March 27, 2023 11:31

codeball-ai-writer bot added the codeball:needs-careful-review label Mar 27, 2023

dborovcanin force-pushed the call-home branch from 0c97c71 to 19c5592 Compare March 27, 2023 11:36

rodneyosodo requested changes Mar 28, 2023

View reviewed changes

dborovcanin changed the title ~~NOISSUE - Call home~~ NOISSUE - Add Call Home Client to Mainflux services Mar 28, 2023

SammyOina force-pushed the call-home branch from 71b01d2 to 1df5d5e Compare March 28, 2023 13:46

SammyOina marked this pull request as draft March 29, 2023 10:01

dborovcanin force-pushed the call-home branch from 774995e to e959b67 Compare April 17, 2023 12:28

SammyOina force-pushed the call-home branch from e959b67 to 333553f Compare April 22, 2023 20:26

SammyOina marked this pull request as ready for review April 23, 2023 18:26

SammyOina requested a review from rodneyosodo April 23, 2023 18:26

rodneyosodo requested changes Apr 24, 2023

View reviewed changes

http/README.md Outdated Show resolved Hide resolved

lora/README.md Outdated Show resolved Hide resolved

mqtt/README.md Outdated Show resolved Hide resolved

opcua/README.md Outdated Show resolved Hide resolved

SammyOina requested a review from rodneyosodo April 27, 2023 12:21

drasko approved these changes Apr 27, 2023

View reviewed changes

drasko requested changes Apr 27, 2023

View reviewed changes

rodneyosodo requested changes Apr 28, 2023

View reviewed changes

mqtt/README.md Outdated Show resolved Hide resolved

mqtt/README.md Outdated Show resolved Hide resolved

mqtt/README.md Outdated Show resolved Hide resolved

mqtt/README.md Outdated Show resolved Hide resolved

SammyOina requested review from drasko and rodneyosodo April 28, 2023 13:40

SammyOina force-pushed the call-home branch from 0ba8726 to 8dc09be Compare May 18, 2023 08:23

SammyOina force-pushed the call-home branch 2 times, most recently from cbb5bb7 to 2bc952c Compare May 31, 2023 13:13

dborovcanin removed the codeball:needs-careful-review label Jun 6, 2023

dborovcanin requested changes Jun 7, 2023

View reviewed changes

SammyOina changed the base branch from master to clients June 7, 2023 07:03

SammyOina force-pushed the call-home branch from 8217f86 to 71ca98c Compare June 7, 2023 08:39

SammyOina requested a review from dborovcanin June 7, 2023 09:02

dborovcanin requested changes Jun 7, 2023

View reviewed changes

vendor/github.com/mainflux/callhome/pkg/client/client.go Outdated Show resolved Hide resolved

cmd/coap/main.go Outdated Show resolved Hide resolved

vendor/github.com/mainflux/callhome/pkg/client/client.go Show resolved Hide resolved

rodneyosodo reviewed Jun 7, 2023

View reviewed changes

http/README.md Outdated Show resolved Hide resolved

SammyOina added 24 commits June 14, 2023 11:02

add last seen

ff366b6

Signed-off-by: SammyOina <sammyoina@gmail.com>

rename logger

3e493aa

Signed-off-by: SammyOina <sammyoina@gmail.com>

remove homing client

0597dbd

Signed-off-by: SammyOina <sammyoina@gmail.com>

use unmerged repo

00b223d

Signed-off-by: SammyOina <sammyoina@gmail.com>

use renamed module

5f581fa

Signed-off-by: SammyOina <sammyoina@gmail.com>

update call home version

3880748

Signed-off-by: SammyOina <sammyoina@gmail.com>

edit documentation

ba6f5d6

Signed-off-by: SammyOina <sammyoina@gmail.com>

align table

6f3c1eb

Signed-off-by: SammyOina <sammyoina@gmail.com>

use alias for call home client

9ae4df6

Signed-off-by: SammyOina <sammyoina@gmail.com>

update callhome

c890d6e

Signed-off-by: SammyOina <sammyoina@gmail.com>

update call home pkg

22dd239

Signed-off-by: SammyOina <sammyoina@gmail.com>

update call home

2126e9a

Signed-off-by: SammyOina <sammyoina@gmail.com>

fix modules

6ded640

Signed-off-by: SammyOina <sammyoina@gmail.com>

use mf build version

c86d123

Signed-off-by: SammyOina <sammyoina@gmail.com>

use mf build version

adfd69f

Signed-off-by: SammyOina <sammyoina@gmail.com>

restore default

c6bb7e9

Signed-off-by: SammyOina <sammyoina@gmail.com>

add call home for users and things

05d9db1

Signed-off-by: SammyOina <sammyoina@gmail.com>

enable opting on call home

14c8024

Signed-off-by: SammyOina <sammyoina@gmail.com>

remove full stops

a2ca821

Signed-off-by: SammyOina <sammyoina@gmail.com>

update callhome client

5b430ed

Signed-off-by: SammyOina <sammyoina@gmail.com>

add call home to all services

65ba929

Signed-off-by: SammyOina <sammyoina@gmail.com>

fix build

5148293

Signed-off-by: SammyOina <sammyoina@gmail.com>

restore sdk tests

c717647

Signed-off-by: SammyOina <sammyoina@gmail.com>

remove unnecessary changes

dc781cc

Signed-off-by: SammyOina <sammyoina@gmail.com>

SammyOina force-pushed the call-home branch from 1763f65 to dc781cc Compare June 14, 2023 08:19

restore health_test.go

80d57df

Signed-off-by: SammyOina <sammyoina@gmail.com>

dborovcanin approved these changes Jun 14, 2023

View reviewed changes

dborovcanin merged commit c60dc4b into absmach:clients Jun 14, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NOISSUE - Add Call Home Client to Mainflux services #1751

NOISSUE - Add Call Home Client to Mainflux services #1751

SammyOina commented Mar 27, 2023

codecov-commenter commented Mar 27, 2023 •

edited by codecov bot

Loading

drasko left a comment

drasko Apr 27, 2023

dborovcanin left a comment

dborovcanin left a comment •

edited

Loading

NOISSUE - Add Call Home Client to Mainflux services #1751

NOISSUE - Add Call Home Client to Mainflux services #1751

Conversation

SammyOina commented Mar 27, 2023

What does this do?

Which issue(s) does this PR fix/relate to?

List any changes that modify/break current functionality

Have you included tests for your changes?

Did you document any new/modified functionality?

Notes

codecov-commenter commented Mar 27, 2023 • edited by codecov bot Loading

Codecov Report

drasko left a comment

Choose a reason for hiding this comment

drasko Apr 27, 2023

Choose a reason for hiding this comment

dborovcanin left a comment

Choose a reason for hiding this comment

dborovcanin left a comment • edited Loading

Choose a reason for hiding this comment

codecov-commenter commented Mar 27, 2023 •

edited by codecov bot

Loading

dborovcanin left a comment •

edited

Loading