NOISSUE - Update Add and Delete Policies #1792

rodneyosodo · 2023-05-11T10:55:26Z

What does this do?

AddPolicy adds a policy is added if:

The client is an admin
The client has g_add action on the object.
The client is the owner of the subject.

checkPolicy checks for the following:

Check if the client is an admin
Check if the client is the owner of the policy

Which issue(s) does this PR fix/relate to?

Noissue

List any changes that modify/break current functionality

Have you included tests for your changes?

No

Did you document any new/modified functionality?

Yes

Notes

N/A

codecov-commenter · 2023-05-15T08:15:53Z

Codecov Report

Merging #1792 (08fd6b2) into clients (7eea06f) will decrease coverage by 7.57%.
The diff coverage is 57.23%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##           clients    #1792      +/-   ##
===========================================
- Coverage    69.99%   62.43%   -7.57%     
===========================================
  Files          149      115      -34     
  Lines        11816     9302    -2514     
===========================================
- Hits          8271     5808    -2463     
- Misses        2875     2880       +5     
+ Partials       670      614      -56

Impacted Files	Coverage Δ
bootstrap/redis/producer/streams.go	`56.89% <ø> (-31.06%)`	⬇️
bootstrap/service.go	`80.45% <ø> (-2.66%)`	⬇️
certs/postgres/certs.go	`0.00% <ø> (ø)`
certs/service.go	`83.13% <ø> (ø)`
consumers/notifiers/api/transport.go	`91.01% <ø> (ø)`
consumers/notifiers/postgres/database.go	`74.19% <ø> (+24.19%)`	⬆️
consumers/notifiers/service.go	`60.00% <ø> (ø)`
http/api/transport.go	`69.30% <ø> (ø)`
mqtt/forwarder.go	`0.00% <ø> (ø)`
mqtt/handler.go	`92.98% <ø> (ø)`
... and 18 more

... and 44 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

dborovcanin

Add in a new policy flow goes like this:

Check if I'm Admin
Check if I'm a member of the group with right to add members (not necessarily the owner of the group)
Check if I'm adding a thing or a user (we'll need that info in the request, default is thing type):
- if user, use gRPC to check if the user exits (in the future - if the user exists and is in the same scope)
- if thing, check if the thing is owned by me (in the future, maybe some other checks such if the thing is already shared with me)

drasko · 2023-05-31T12:01:03Z

things/policies/service.go

+	req := &upolicies.AuthorizeReq{
+		Sub:        id,
+		Obj:        thingsObjectKey,
+		Act:        "c_update", // TODO: remove since this is not used


Do we need this TODO?

Yes. @dborovcanin had suggested we move admin check to JWT layer so that we have role information in the JWT token

drasko · 2023-05-31T12:01:32Z

things/groups/service.go

+	return svc.policies.Authorize(ctx, entityType, policy)
+}
+
+// TODO : Only accept token as parameter since object and action are irrelevant.


Do we need this TODO?

drasko · 2023-05-31T12:01:59Z

things/clients/service.go

+	return svc.policies.Authorize(ctx, clientEntityType, policy)
+}
+
+// TODO : Only accept token as parameter since object and action are irrelevant.


Do we need this TODO?

dborovcanin

@rodneyosodo Please check @drasko's comments and address (or answer) them.

Signed-off-by: rodneyosodo <blackd0t@protonmail.com>

… on Ownership Signed-off-by: rodneyosodo <blackd0t@protonmail.com>

Signed-off-by: rodneyosodo <blackd0t@protonmail.com>

* Remove Policy Action Ranks Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Rebase Issues Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix CI Test Errors Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Adding Check on Subject For Clients Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Remove Check Client Exists Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Check When Sharing Clients Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Only Add User to Group When Sharing Things Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Remove clientType Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Minor Fix on ShareClient and Fix Tests Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Policies Tests Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Clean Up Things Authorization Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Tests on RetrieveAll Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Test ShareThing Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Merge Conflicts Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Remove Adding Policies. Only Use Ownership Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Check If Subject is same as Object Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Move Back To Union As Sometimes Policy is Empty and Fails to Evaluate on Ownership Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Entity Type For Failing Tests Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix BUG in policy evaluation Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Tests Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Add Comments Regarding checkAdmin Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Tests On Rebase Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Combine Authorize For Things and Users Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Tests On Rebase Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Error on Things SVC `unsupported protocol scheme` Signed-off-by: rodneyosodo <blackd0t@protonmail.com> --------- Signed-off-by: rodneyosodo <blackd0t@protonmail.com>

* Remove Policy Action Ranks Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Rebase Issues Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix CI Test Errors Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Adding Check on Subject For Clients Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Remove Check Client Exists Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Check When Sharing Clients Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Only Add User to Group When Sharing Things Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Remove clientType Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Minor Fix on ShareClient and Fix Tests Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Policies Tests Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Clean Up Things Authorization Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Tests on RetrieveAll Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Test ShareThing Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Merge Conflicts Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Remove Adding Policies. Only Use Ownership Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Check If Subject is same as Object Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Move Back To Union As Sometimes Policy is Empty and Fails to Evaluate on Ownership Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Entity Type For Failing Tests Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix BUG in policy evaluation Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Tests Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Add Comments Regarding checkAdmin Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Tests On Rebase Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Combine Authorize For Things and Users Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Tests On Rebase Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Error on Things SVC `unsupported protocol scheme` Signed-off-by: rodneyosodo <blackd0t@protonmail.com> --------- Signed-off-by: rodneyosodo <blackd0t@protonmail.com> Signed-off-by: SammyOina <sammyoina@gmail.com>

* Remove Policy Action Ranks Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Rebase Issues Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix CI Test Errors Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Adding Check on Subject For Clients Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Remove Check Client Exists Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Check When Sharing Clients Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Only Add User to Group When Sharing Things Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Remove clientType Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Minor Fix on ShareClient and Fix Tests Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Policies Tests Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Clean Up Things Authorization Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Tests on RetrieveAll Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Test ShareThing Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Merge Conflicts Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Remove Adding Policies. Only Use Ownership Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Check If Subject is same as Object Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Move Back To Union As Sometimes Policy is Empty and Fails to Evaluate on Ownership Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Entity Type For Failing Tests Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix BUG in policy evaluation Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Tests Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Add Comments Regarding checkAdmin Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Tests On Rebase Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Combine Authorize For Things and Users Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Tests On Rebase Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Error on Things SVC `unsupported protocol scheme` Signed-off-by: rodneyosodo <blackd0t@protonmail.com> --------- Signed-off-by: rodneyosodo <blackd0t@protonmail.com> Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com>

* Move Things and Users to Clients Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com> Signed-off-by: rodneyosodo <blackd0t@protonmail.com> Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com> * NOISSUE - Update Add and Delete Policies (#1792) * Remove Policy Action Ranks Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Rebase Issues Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix CI Test Errors Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Adding Check on Subject For Clients Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Remove Check Client Exists Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Check When Sharing Clients Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Only Add User to Group When Sharing Things Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Remove clientType Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Minor Fix on ShareClient and Fix Tests Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Policies Tests Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Clean Up Things Authorization Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Tests on RetrieveAll Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Test ShareThing Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Merge Conflicts Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Remove Adding Policies. Only Use Ownership Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Check If Subject is same as Object Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Move Back To Union As Sometimes Policy is Empty and Fails to Evaluate on Ownership Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Entity Type For Failing Tests Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix BUG in policy evaluation Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Tests Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Add Comments Regarding checkAdmin Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Tests On Rebase Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Combine Authorize For Things and Users Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Tests On Rebase Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Error on Things SVC `unsupported protocol scheme` Signed-off-by: rodneyosodo <blackd0t@protonmail.com> --------- Signed-off-by: rodneyosodo <blackd0t@protonmail.com> Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com> * Fix Bug on Things Authorization Cache (#1810) Signed-off-by: rodneyosodo <blackd0t@protonmail.com> Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com> * Use Password instead of username in MQTT handler Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com> * Simplify MQTT authorization Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com> * Fix MQTT tests Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com> * NOISSUE - Add More Functions to SDK (#1811) * Add More Functions to SDK Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Add Examples to GoDoc Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Update Unassign Interface Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Pass Subject as ID and Not Token on List Channels By Thing Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Bootstrap Errors For Element Check Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Add empty line Before Return Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Reorder URLS in things mux Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Listing Things Policies Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Share Thing Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Add Examples to CLI Docs Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Update Identity To Update Another User Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Identify an Update Policies on Things Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Update Things Policies Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix GoDocs on Disconnect Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Tests Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Change Authorize To Use AccessRequest Signed-off-by: rodneyosodo <blackd0t@protonmail.com> --------- Signed-off-by: rodneyosodo <blackd0t@protonmail.com> Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com> * For Evaluate Policy Use AccessRequest (#1814) Signed-off-by: rodneyosodo <blackd0t@protonmail.com> Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com> * NOISSUE - Add SDK Tests (#1812) * Add Things Tests Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Add Channel Tests Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Add Certs Tests Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Add Consumer Tests Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Enrich Group Tests Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Add Tests For Health Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Add Tests For Tokens Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Rename SDK for Tests Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Add Policies Tests Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Linter Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Tests Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Make Variable Defination Inline Signed-off-by: rodneyosodo <blackd0t@protonmail.com> --------- Signed-off-by: rodneyosodo <blackd0t@protonmail.com> Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com> * NOISSUE - Make Cache Key Duration Configurable (#1815) * Make Cache Key Duration Configurable Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Rename ENV Var Signed-off-by: rodneyosodo <blackd0t@protonmail.com> --------- Signed-off-by: rodneyosodo <blackd0t@protonmail.com> Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com> * NOISSUE - Update GoDocs (#1816) * Add GoDocs Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Add Missing GoDoc Files Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Enable godot Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Add License Information Signed-off-by: rodneyosodo <blackd0t@protonmail.com> --------- Signed-off-by: rodneyosodo <blackd0t@protonmail.com> Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com> * NOISSUE - Add Call Home Client to Mainflux services (#1751) * Move Things and Users to Clients Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com> Signed-off-by: rodneyosodo <blackd0t@protonmail.com> Signed-off-by: SammyOina <sammyoina@gmail.com> * collect and send data package Signed-off-by: SammyOina <sammyoina@gmail.com> * create telemetry migrations Signed-off-by: SammyOina <sammyoina@gmail.com> * add telemetry endpoints Signed-off-by: SammyOina <sammyoina@gmail.com> * add transport Signed-off-by: SammyOina <sammyoina@gmail.com> * create service Signed-off-by: SammyOina <sammyoina@gmail.com> * remove homing server Signed-off-by: SammyOina <sammyoina@gmail.com> * add call home to adapters Signed-off-by: SammyOina <sammyoina@gmail.com> * add last seen Signed-off-by: SammyOina <sammyoina@gmail.com> * rename logger Signed-off-by: SammyOina <sammyoina@gmail.com> * remove homing client Signed-off-by: SammyOina <sammyoina@gmail.com> * use unmerged repo Signed-off-by: SammyOina <sammyoina@gmail.com> * use renamed module Signed-off-by: SammyOina <sammyoina@gmail.com> * update call home version Signed-off-by: SammyOina <sammyoina@gmail.com> * edit documentation Signed-off-by: SammyOina <sammyoina@gmail.com> * align table Signed-off-by: SammyOina <sammyoina@gmail.com> * use alias for call home client Signed-off-by: SammyOina <sammyoina@gmail.com> * update callhome Signed-off-by: SammyOina <sammyoina@gmail.com> * update call home pkg Signed-off-by: SammyOina <sammyoina@gmail.com> * update call home Signed-off-by: SammyOina <sammyoina@gmail.com> * fix modules Signed-off-by: SammyOina <sammyoina@gmail.com> * use mf build version Signed-off-by: SammyOina <sammyoina@gmail.com> * use mf build version Signed-off-by: SammyOina <sammyoina@gmail.com> * restore default Signed-off-by: SammyOina <sammyoina@gmail.com> * add call home for users and things Signed-off-by: SammyOina <sammyoina@gmail.com> * enable opting on call home Signed-off-by: SammyOina <sammyoina@gmail.com> * remove full stops Signed-off-by: SammyOina <sammyoina@gmail.com> * update callhome client Signed-off-by: SammyOina <sammyoina@gmail.com> * add call home to all services Signed-off-by: SammyOina <sammyoina@gmail.com> * fix build Signed-off-by: SammyOina <sammyoina@gmail.com> * restore sdk tests Signed-off-by: SammyOina <sammyoina@gmail.com> * remove unnecessary changes Signed-off-by: SammyOina <sammyoina@gmail.com> * restore health_test.go Signed-off-by: SammyOina <sammyoina@gmail.com> --------- Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com> Signed-off-by: rodneyosodo <blackd0t@protonmail.com> Signed-off-by: SammyOina <sammyoina@gmail.com> Co-authored-by: b1ackd0t <blackd0t@protonmail.com> Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com> --------- Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com> Signed-off-by: rodneyosodo <blackd0t@protonmail.com> Signed-off-by: SammyOina <sammyoina@gmail.com> Co-authored-by: b1ackd0t <blackd0t@protonmail.com> Co-authored-by: Sammy Kerata Oina <44265300+SammyOina@users.noreply.github.com>

rodneyosodo requested a review from a team as a code owner May 11, 2023 10:55

rodneyosodo force-pushed the NOISSUE-updatesonclientpolicies branch 4 times, most recently from 376aebb to bde4c3e Compare May 15, 2023 07:58

rodneyosodo force-pushed the NOISSUE-updatesonclientpolicies branch from bde4c3e to 8f40019 Compare May 16, 2023 18:11

dborovcanin requested changes May 18, 2023

View reviewed changes

rodneyosodo force-pushed the NOISSUE-updatesonclientpolicies branch from ee17e22 to 11e2000 Compare May 29, 2023 13:43

dborovcanin force-pushed the clients branch 2 times, most recently from d0357fa to adeff36 Compare May 30, 2023 20:09

rodneyosodo force-pushed the NOISSUE-updatesonclientpolicies branch 2 times, most recently from 18f3623 to e57bc06 Compare May 31, 2023 09:06

drasko requested changes May 31, 2023

View reviewed changes

dborovcanin force-pushed the clients branch 3 times, most recently from 926557e to 4f375d2 Compare May 31, 2023 14:19

rodneyosodo force-pushed the NOISSUE-updatesonclientpolicies branch from 95be9c6 to 4f17142 Compare May 31, 2023 14:55

dborovcanin requested changes May 31, 2023

View reviewed changes

rodneyosodo force-pushed the NOISSUE-updatesonclientpolicies branch 5 times, most recently from 8bb8f07 to 08fd6b2 Compare June 6, 2023 11:39

dborovcanin force-pushed the clients branch from 0d9a073 to 0e75bd5 Compare June 6, 2023 11:42

rodneyosodo added 5 commits June 6, 2023 15:04

Remove Policy Action Ranks

a68acbc

Signed-off-by: rodneyosodo <blackd0t@protonmail.com>

Fix Rebase Issues

4316292

Signed-off-by: rodneyosodo <blackd0t@protonmail.com>

Fix CI Test Errors

b14444a

Signed-off-by: rodneyosodo <blackd0t@protonmail.com>

Adding Check on Subject For Clients

6d49341

Signed-off-by: rodneyosodo <blackd0t@protonmail.com>

Remove Check Client Exists

2f34b82

Signed-off-by: rodneyosodo <blackd0t@protonmail.com>

rodneyosodo added 20 commits June 6, 2023 15:04

Check When Sharing Clients

6075698

Signed-off-by: rodneyosodo <blackd0t@protonmail.com>

Only Add User to Group When Sharing Things

239b059

Signed-off-by: rodneyosodo <blackd0t@protonmail.com>

Remove clientType

fd1ed17

Signed-off-by: rodneyosodo <blackd0t@protonmail.com>

Minor Fix on ShareClient and Fix Tests

c087306

Signed-off-by: rodneyosodo <blackd0t@protonmail.com>

Fix Policies Tests

3e2eee0

Signed-off-by: rodneyosodo <blackd0t@protonmail.com>

Clean Up Things Authorization

d197353

Signed-off-by: rodneyosodo <blackd0t@protonmail.com>

Fix Tests on RetrieveAll

78c034e

Signed-off-by: rodneyosodo <blackd0t@protonmail.com>

Test ShareThing

dcba4b8

Signed-off-by: rodneyosodo <blackd0t@protonmail.com>

Fix Merge Conflicts

d399fc3

Signed-off-by: rodneyosodo <blackd0t@protonmail.com>

Remove Adding Policies. Only Use Ownership

81b9d22

Signed-off-by: rodneyosodo <blackd0t@protonmail.com>

Check If Subject is same as Object

eeef3e7

Signed-off-by: rodneyosodo <blackd0t@protonmail.com>

Move Back To Union As Sometimes Policy is Empty and Fails to Evaluate…

b6dee2c

… on Ownership Signed-off-by: rodneyosodo <blackd0t@protonmail.com>

Fix Entity Type For Failing Tests

0fb8854

Signed-off-by: rodneyosodo <blackd0t@protonmail.com>

Fix BUG in policy evaluation

3f9e8b9

Signed-off-by: rodneyosodo <blackd0t@protonmail.com>

Fix Tests

3adeced

Signed-off-by: rodneyosodo <blackd0t@protonmail.com>

Add Comments Regarding checkAdmin

185c1a2

Signed-off-by: rodneyosodo <blackd0t@protonmail.com>

Fix Tests On Rebase

57adee5

Signed-off-by: rodneyosodo <blackd0t@protonmail.com>

Combine Authorize For Things and Users

3c3b4c4

Signed-off-by: rodneyosodo <blackd0t@protonmail.com>

Fix Tests On Rebase

3db17e8

Signed-off-by: rodneyosodo <blackd0t@protonmail.com>

Error on Things SVC unsupported protocol scheme

bc2e689

Signed-off-by: rodneyosodo <blackd0t@protonmail.com>

rodneyosodo force-pushed the NOISSUE-updatesonclientpolicies branch from 42b802d to bc2e689 Compare June 6, 2023 12:08

dborovcanin approved these changes Jun 6, 2023

View reviewed changes

dborovcanin merged commit 6e49df6 into absmach:clients Jun 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NOISSUE - Update Add and Delete Policies #1792

NOISSUE - Update Add and Delete Policies #1792

rodneyosodo commented May 11, 2023 •

edited

Loading

codecov-commenter commented May 15, 2023 •

edited

Loading

dborovcanin left a comment

drasko May 31, 2023

rodneyosodo May 31, 2023

drasko May 31, 2023

drasko May 31, 2023

dborovcanin left a comment

NOISSUE - Update Add and Delete Policies #1792

NOISSUE - Update Add and Delete Policies #1792

Conversation

rodneyosodo commented May 11, 2023 • edited Loading

What does this do?

Which issue(s) does this PR fix/relate to?

List any changes that modify/break current functionality

Have you included tests for your changes?

Did you document any new/modified functionality?

Notes

codecov-commenter commented May 15, 2023 • edited Loading

Codecov Report

dborovcanin left a comment

Choose a reason for hiding this comment

drasko May 31, 2023

Choose a reason for hiding this comment

rodneyosodo May 31, 2023

Choose a reason for hiding this comment

drasko May 31, 2023

Choose a reason for hiding this comment

drasko May 31, 2023

Choose a reason for hiding this comment

dborovcanin left a comment

Choose a reason for hiding this comment

rodneyosodo commented May 11, 2023 •

edited

Loading

codecov-commenter commented May 15, 2023 •

edited

Loading