Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Add Tracing To Certs Service #1850

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

rodneyosodo
Copy link
Member

Signed-off-by: rodneyosodo blackd0t@protonmail.com

What does this do?

Add tracing to the certs service

Which issue(s) does this PR fix/relate to?

No issue

List any changes that modify/break current functionality

  • Added context to repository functions on Certs
  • Use NamedQueryContext instead of NamedQuery

Have you included tests for your changes?

No

Did you document any new/modified functionality?

No

Notes

To be merged after #1849

@rodneyosodo rodneyosodo requested a review from a team as a code owner July 5, 2023 18:15
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #1850 (8817c3b) into master (cc0b90a) will decrease coverage by 1.57%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1850      +/-   ##
==========================================
- Coverage   65.68%   64.12%   -1.57%     
==========================================
  Files         116      118       +2     
  Lines        9413     9642     +229     
==========================================
  Hits         6183     6183              
- Misses       2572     2801     +229     
  Partials      658      658              
Impacted Files Coverage Δ
certs/postgres/certs.go 0.00% <0.00%> (ø)
twins/redis/events.go 0.00% <0.00%> (ø)
twins/redis/streams.go 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rodneyosodo rodneyosodo force-pushed the NOISSUE-tracecerts branch 5 times, most recently from 7428595 to ddbf5c6 Compare July 10, 2023 12:28
cmd/certs/main.go Outdated Show resolved Hide resolved
@rodneyosodo rodneyosodo force-pushed the NOISSUE-tracecerts branch 3 times, most recently from 5826b88 to 60bee29 Compare July 12, 2023 08:50
Signed-off-by: rodneyosodo <blackd0t@protonmail.com>
Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drasko drasko merged commit 1192325 into absmach:master Jul 12, 2023
1 of 3 checks passed
WashingtonKK pushed a commit to WashingtonKK/magistrala that referenced this pull request Jul 12, 2023
Signed-off-by: rodneyosodo <blackd0t@protonmail.com>
WashingtonKK pushed a commit to WashingtonKK/magistrala that referenced this pull request Jul 12, 2023
Signed-off-by: rodneyosodo <blackd0t@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants