Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Add Tracing To Bootstrap Service #1849

Merged
merged 2 commits into from
Jul 7, 2023

Conversation

rodneyosodo
Copy link
Member

Signed-off-by: rodneyosodo blackd0t@protonmail.com

What does this do?

Add tracing to the bootstrap service

Which issue(s) does this PR fix/relate to?

No issue

List any changes that modify/break current functionality

  • Added context to repository functions on Bootstrap
  • Use NamedQueryContext instead of NamedQuery

Have you included tests for your changes?

No

Did you document any new/modified functionality?

No

Notes

To be merged after #1847

@rodneyosodo rodneyosodo requested a review from a team as a code owner July 5, 2023 17:14
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #1849 (18c4847) into master (412593a) will not change coverage.
The diff coverage is 74.13%.

@@           Coverage Diff           @@
##           master    #1849   +/-   ##
=======================================
  Coverage   65.68%   65.68%           
=======================================
  Files         116      116           
  Lines        9413     9413           
=======================================
  Hits         6183     6183           
  Misses       2572     2572           
  Partials      658      658           
Impacted Files Coverage Δ
bootstrap/service.go 80.45% <64.70%> (ø)
bootstrap/postgres/configs.go 69.28% <78.04%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: rodneyosodo <blackd0t@protonmail.com>
Signed-off-by: rodneyosodo <blackd0t@protonmail.com>
Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drasko drasko merged commit 604949e into absmach:master Jul 7, 2023
3 checks passed
ianmuchyri added a commit to ianmuchyri/magistrala that referenced this pull request Jul 7, 2023
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
drasko pushed a commit that referenced this pull request Jul 7, 2023
* update or to sync with clients branch

Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>

* Add empty lines

Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>

* update inline constant

Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>

* rebase pr to sync with master branch

Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>

* update pr to sync with updated master #1849

Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>

---------

Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
WashingtonKK pushed a commit to WashingtonKK/magistrala that referenced this pull request Jul 12, 2023
* Initial Commit: Remove JaegerURL from grpc Client Config

Signed-off-by: rodneyosodo <blackd0t@protonmail.com>

* Initial Commit: Add Tracing To Bootstrap Service

Signed-off-by: rodneyosodo <blackd0t@protonmail.com>

---------

Signed-off-by: rodneyosodo <blackd0t@protonmail.com>
WashingtonKK pushed a commit to WashingtonKK/magistrala that referenced this pull request Jul 12, 2023
* update or to sync with clients branch

Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>

* Add empty lines

Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>

* update inline constant

Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>

* rebase pr to sync with master branch

Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>

* update pr to sync with updated master absmach#1849

Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>

---------

Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
WashingtonKK pushed a commit to WashingtonKK/magistrala that referenced this pull request Jul 12, 2023
* Initial Commit: Remove JaegerURL from grpc Client Config

Signed-off-by: rodneyosodo <blackd0t@protonmail.com>

* Initial Commit: Add Tracing To Bootstrap Service

Signed-off-by: rodneyosodo <blackd0t@protonmail.com>

---------

Signed-off-by: rodneyosodo <blackd0t@protonmail.com>
WashingtonKK pushed a commit to WashingtonKK/magistrala that referenced this pull request Jul 12, 2023
* update or to sync with clients branch

Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>

* Add empty lines

Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>

* update inline constant

Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>

* rebase pr to sync with master branch

Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>

* update pr to sync with updated master absmach#1849

Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>

---------

Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants