NOISSUE - Add traces to API Bootstraps and Certs endpoints #1851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SammyOina
changed the title
|
Is it a duplicate of https://github.com/mainflux/mainflux/pull/1849 ? |
Codecov Report
@@ Coverage Diff @@
## master #1851 +/- ##
=======================================
Coverage 65.68% 65.68%
=======================================
Files 116 116
Lines 9413 9413
=======================================
Hits 6183 6183
Misses 2572 2572
Partials 658 658
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
SammyOina
changed the title
No it is not a duplicate |
rodneyosodo
requested changes
Jul 6, 2023
rodneyosodo
requested changes
Jul 11, 2023
Signed-off-by: SammyOina <sammyoina@gmail.com>
Signed-off-by: SammyOina <sammyoina@gmail.com>
Signed-off-by: SammyOina <sammyoina@gmail.com>
Signed-off-by: SammyOina <sammyoina@gmail.com>
Signed-off-by: SammyOina <sammyoina@gmail.com>
Co-authored-by: b1ackd0t <blackd0t@protonmail.com> Signed-off-by: SammyOina <sammyoina@gmail.com>
dborovcanin
approved these changes
Jul 11, 2023
WashingtonKK
pushed a commit
to WashingtonKK/magistrala
that referenced
this pull request
Jul 12, 2023
) * add traces to bootstrap endpoints Signed-off-by: SammyOina <sammyoina@gmail.com> * add tracing to certs endpoints Signed-off-by: SammyOina <sammyoina@gmail.com> * remove tracing provider Signed-off-by: SammyOina <sammyoina@gmail.com> * add tracing provider Signed-off-by: SammyOina <sammyoina@gmail.com> * add tracing provider Signed-off-by: SammyOina <sammyoina@gmail.com> * Update cmd/certs/main.go Co-authored-by: b1ackd0t <blackd0t@protonmail.com> Signed-off-by: SammyOina <sammyoina@gmail.com> --------- Signed-off-by: SammyOina <sammyoina@gmail.com> Co-authored-by: b1ackd0t <blackd0t@protonmail.com>
WashingtonKK
pushed a commit
to WashingtonKK/magistrala
that referenced
this pull request
Jul 12, 2023
) * add traces to bootstrap endpoints Signed-off-by: SammyOina <sammyoina@gmail.com> * add tracing to certs endpoints Signed-off-by: SammyOina <sammyoina@gmail.com> * remove tracing provider Signed-off-by: SammyOina <sammyoina@gmail.com> * add tracing provider Signed-off-by: SammyOina <sammyoina@gmail.com> * add tracing provider Signed-off-by: SammyOina <sammyoina@gmail.com> * Update cmd/certs/main.go Co-authored-by: b1ackd0t <blackd0t@protonmail.com> Signed-off-by: SammyOina <sammyoina@gmail.com> --------- Signed-off-by: SammyOina <sammyoina@gmail.com> Co-authored-by: b1ackd0t <blackd0t@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Adds server spans to bootstrap and certs services.
Which issue(s) does this PR fix/relate to?
Noissue
List any changes that modify/break current functionality
None
Have you included tests for your changes?
No
Did you document any new/modified functionality?
No
Notes