NOISSUE - Remove Development Mode on Certs Creation #1908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1908 +/- ##
=======================================
Coverage 67.14% 67.14%
=======================================
Files 120 120
Lines 9145 9145
=======================================
Hits 6140 6140
Misses 2368 2368
Partials 637 637 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
SammyOina
approved these changes
Sep 14, 2023
rodneyosodo
force-pushed
the
noissue-certs-dev
branch
from
88e81c4
to
f83a172
Compare
dborovcanin
force-pushed
the
noissue-certs-dev
branch
from
f83a172
to
4021607
Compare
rodneyosodo
force-pushed
the
noissue-certs-dev
branch
2 times, most recently
from
156995a
to
19d16fe
Compare
dborovcanin
approved these changes
Oct 17, 2023
drasko
force-pushed
the
noissue-certs-dev
branch
from
19d16fe
to
5bf0b55
Compare
rodneyosodo
force-pushed
the
noissue-certs-dev
branch
from
5bf0b55
to
7193bc4
Compare
This commit removes certificate creation in development mode. Previously, the `MF_CERTS_VAULT_HOST` environment variable was not being properly checked, resulting in incorrect behavior when issuing certificates. This commit ensures that the correct mode is set based on the value of `MF_CERTS_VAULT_HOST`. Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
The README.md file has been updated to clarify the process of revoking certificates. The previous instructions were incorrect, and the correct method is now provided. The certificates can be revoked using the `certs` service by providing the `thing_id` of the thing for which the certificate was issued.
```
curl -s -S -X DELETE http://localhost:9019/certs/revoke -H "Authorization: Bearer $TOK" -H 'Content-Type: application/json' -d '{"thing_id":"c30b8842-507c-4bcd-973c-74008cef3be5"}'
```
Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
drasko
force-pushed
the
noissue-certs-dev
branch
from
7193bc4
to
e9ed2e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit ensures that the correct mode is set based on the value of
MF_CERTS_VAULT_HOST.What does this do?
Remove documentation for development mode. Since we only support PKI mode. I have created an issue to work on development mode.
Which issue(s) does this PR fix/relate to?
No issue
List any changes that modify/break current functionality
Previously, the
MF_CERTS_VAULT_HOSTenvironment variable was being checked, resulting in incorrect behaviour when issuing certificates in development mode as we need a valid host.https://github.com/mainflux/mainflux/blob/65b63742354b9ad91f5ab6ac6bb74b6481311db8/cmd/certs/main.go#L89C1-L93C3Have you included tests for your changes?
No
Did you document any new/modified functionality?
Yes
Notes
Linked to https://github.com/ultravioletrs/issues/issues/314 absmach/magistrala-docs#161