Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NOISSUE - Remove Development Mode on Certs Creation #1908

Merged
merged 2 commits into from
Oct 18, 2023
Merged

NOISSUE - Remove Development Mode on Certs Creation #1908

merged 2 commits into from
Oct 18, 2023

Commits on Oct 18, 2023

  1. Fix certificate creation in development mode 

    This commit removes certificate creation in development mode. Previously, the `MF_CERTS_VAULT_HOST` environment variable was not being properly checked, resulting in incorrect behavior when issuing certificates. This commit ensures that the correct mode is set based on the value of `MF_CERTS_VAULT_HOST`.

Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
    @rodneyosodo @drasko
    rodneyosodo authored and drasko committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    c4a186b View commit details
    Browse the repository at this point in the history

  2. Fix certificate revocation in README.md 

    The README.md file has been updated to clarify the process of revoking certificates. The previous instructions were incorrect, and the correct method is now provided. The certificates can be revoked using the `certs` service by providing the `thing_id` of the thing for which the certificate was issued.

```
curl -s -S -X DELETE http://localhost:9019/certs/revoke -H "Authorization: Bearer $TOK" -H 'Content-Type: application/json' -d '{"thing_id":"c30b8842-507c-4bcd-973c-74008cef3be5"}'
```

Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
    @rodneyosodo @drasko
    rodneyosodo authored and drasko committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    e9ed2e3 View commit details
    Browse the repository at this point in the history