Manually sync ammo globably on belt reload.

[PabstMirror]

Fix #1119 (setAmmo isn't synced immediately)

Belt relinking is rare enough that doing an extra global event shouldn't be that bad.

[nicolasbadano]

I think doing this right might be a bit harder. Due to the MG rate of fire, timing is critical for this setammo commands. That's why I'm letting the local unit calculate how much ammo is actually added upon receiving the event.

The set ammo even global event will arrive later to the rest of the units, that will then set ammo count larger than they should (some of the linked ammo will be consumed on the local client by then).

An improvement would be to broadcast the amount of ammo added on the event, and let each client do the additions themselves. That'd make this precise as long as the mg doesn't deplete the ammo during the time the event is transmiting.

[PabstMirror]

The setAmmoSync event comes from the local unit.

Events and fired events should both be synchronized // guaranteed-order.

So every client should see the setAmmoSync event and then fireEvents in the exact same order and always see the exact same ammo count on the unit.

[nicolasbadano]

Events and fired events should both be synchronized // guaranteed-order.

Are we sure about that @jaynus ?

I know about the guaranteed order of events, but I thought for some reason that engine events and publicvariable events had their own independent queues. Obviously I'm not sure.

Anyway, I agree with @PabstMirror that a global event is worth it, and shouldn't have any perf cost.

[jaynus]

I know about the guaranteed order of events, but I thought for some reason that engine events and publicvariable events had their own independent queues. Obviously I'm not sure.

They share a network queue, so you can always guarantee reception order as the send order in any given frame. I'm not sure about the server propagation side of this (client->server->clients) and whether it maintains order. However, events going out of a system will always be synchronous - the network stack is single order shared.