Akward Sitting Fixes Part 2 #1806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ["medical_onUnconscious", {_this call DFUNC(handleInterrupt)}] call EFUNC(common,addEventhandler); | ||
| ["SetHandcuffed", {_this call DFUNC(handleInterrupt)}] call EFUNC(common,addEventhandler); | ||
| ["SetSurrendered", {_this call DFUNC(handleInterrupt)}] call EFUNC(common,addEventhandler); | ||
| ["medical_onUnconscious", {_player call DFUNC(handleInterrupt)}] call EFUNC(common,addEventhandler); |
There was a problem hiding this comment.
Throwing:
Error position: <_player call ace_sitting_fnc_handleInter>
Error Undefined variable in expression: _player
File z\ace\addons\sitting\XEH_clientInit.sqf, line 10
Test codes:
[] spawn {
[player, true] call ace_medical_fnc_setUnconscious;
sleep 10;
[player, false] call ace_medical_fnc_setUnconscious;
};
[] spawn {
["SetHandcuffed", [player, true]] call ace_common_fnc_localEvent;
sleep 10;
["SetHandcuffed", [player, false]] call ace_common_fnc_localEvent;
};
I don't think this should be changed at all and keep it as _this.
For all 3 events the unit is the first argument, which is what handleInterrupt is expecting.
There was a problem hiding this comment.
Weird, worked just fine for me, I thought I'd remove number of arguments sending. Will fix!
On that note, are there any performance differences in how many arguments you are sending, even if so small it's not worth it?
|
Also removed |
|
This is ready to be merged from my side. I'll work on other fixes in a separate PR (time to learn about CfgMoves). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1796
Read #1795 (comment) for Part 1.