Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACE2 ball tracers port. #378

Merged
merged 8 commits into from
May 29, 2015
Merged

ACE2 ball tracers port. #378

merged 8 commits into from
May 29, 2015

Conversation

jaynus
Copy link
Contributor

@jaynus jaynus commented Apr 7, 2015

This merges in all the ACE2 ball tracers models.

@jaynus jaynus added this to the 3.0.0 milestone Apr 7, 2015
@jaynus jaynus added the kind/enhancement Release Notes: **IMPROVED:** label Apr 7, 2015
@jaynus jaynus assigned jaynus and NouberNou and unassigned jaynus Apr 7, 2015
@jaynus jaynus changed the title ACE2 tracers port. ACE2 ball tracers port. Apr 8, 2015
@nicolasbadano nicolasbadano modified the milestones: 3.1.0, 3.0.0 Apr 21, 2015
@nicolasbadano
Copy link
Contributor

Pushing for later, cause apparently we won't be using them right now

@cych
Copy link

cych commented Apr 28, 2015

ACE 2 had very good tracer effect thick and bright.

Vanila Arma 3 tracers are maybe a bit too thin and not visible enough compared to real one

@jaynus
Copy link
Contributor Author

jaynus commented Apr 28, 2015

There was some arguments back and forth about the laser beams so these weren't implemented.

@cych
Copy link

cych commented Apr 29, 2015

I got solid 1080p arguments for more visible bullet tracers

https://www.youtube.com/watch?v=V8766Nh-oGE
https://www.youtube.com/watch?v=YpseedqNzbg

ACE 2 had it right. A3 effect is just not enough visible, need brighter more intense phosphorous combustion.

@ulteq
Copy link
Contributor

ulteq commented May 17, 2015

Is this ready for merge?

@nicolasbadano
Copy link
Contributor

@ulteq, this PR only contains the ball tracers models from ACE2, but they are not used for any ammo yet. The actual usage should probably be an optional pbo, cause not everyone likes them

@cych, tracer looks shouldn't be evaluated from video footage. Bright lights have much more persistence in the human retina than on video. I've heard people with real military experience say tracers-as-lines are much closer to rl than tracers-as-balls.

@jaynus
Copy link
Contributor Author

jaynus commented May 17, 2015

tracer looks shouldn't be evaluated from video footage

This is why blastcore and JSRS have always been incorrect. What they sound and look like on footage is completely wrong

@ulteq @esteldunedain All we really need to do to integrate this is create an optional pbo which replaces all the appropriate CfgAmmo bullet models.

@ulteq
Copy link
Contributor

ulteq commented May 17, 2015

@jaynus @esteldunedain Thanks for the clarification.

@ulteq ulteq self-assigned this May 19, 2015
@ulteq
Copy link
Contributor

ulteq commented May 19, 2015

Ready for testing.

What do we do with the new classes that did not exist before (e.g. the 30mm rounds)?

@nicolasbadano
Copy link
Contributor

What do we do with the new classes that did not exist before (e.g. the 30mm rounds)?

I think you should appy the ball tracers to them too.

BTW, is that list of tracers complete? It would be very usefull for #1008

@nicolasbadano
Copy link
Contributor

One more thing; should be rename the pbo to "balltracers"??

@ulteq
Copy link
Contributor

ulteq commented May 19, 2015

BTW, is that list of tracers complete?

Yes

One more thing; should be rename the pbo to "balltracers"??

We can't rename it without changing all the p3d files as well.

@jaynus
Copy link
Contributor Author

jaynus commented May 19, 2015

We can't rename it without changing all the p3d files as well.

Easily doable, I already had to do it once. These are all MLODs so there is nothing stopping is from renaming it.

@ulteq
Copy link
Contributor

ulteq commented May 19, 2015

Those ball tracers are pretty ugly by the way.

@jaynus
Copy link
Contributor Author

jaynus commented May 19, 2015

They are 10000x better than the laser beams

@ulteq
Copy link
Contributor

ulteq commented May 20, 2015

Ready for merge.

@ViperMaul
Copy link
Contributor

Any one test and confirm this?

@sargken
Copy link
Contributor

sargken commented May 22, 2015

Bring em back they are alot nicer than the ones currently or make it optional

@jaynus
Copy link
Contributor Author

jaynus commented May 22, 2015

I didn't see any difference on some vanilla weapons. Maybe I was missing something. @ulteq ?

@ulteq
Copy link
Contributor

ulteq commented May 23, 2015

I didn't see any difference on some vanilla weapons.

Which vanilla weapons?

@thojkooi thojkooi assigned thojkooi and unassigned ulteq May 29, 2015
@jaynus
Copy link
Contributor Author

jaynus commented May 29, 2015

My setup was messed up at the time, this is good to merge.

thojkooi added a commit that referenced this pull request May 29, 2015
@thojkooi thojkooi merged commit aee783c into master May 29, 2015
@thojkooi thojkooi deleted the ace2Tracers branch May 29, 2015 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants