Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Medical - Fix epinephrine wake-up chance boost string #7407

Merged
merged 2 commits into from
Jan 9, 2020
Merged

Medical - Fix epinephrine wake-up chance boost string #7407

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea110d5
Medical - Fix epinephrine wake-up chance boost string
jonpas Jan 5, 2020
6ab74c0
Merge branch 'master' into fix-epiwakeup-string
PabstMirror Jan 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions addons/medical/stringtable.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,16 +44,7 @@
<Spanish>La probabilidad de que una unidad estabilizada recupere la conciencia y se levante (se comprueba cada 15 segundos)</Spanish>
</Key>
<Key ID="STR_ACE_Medical_spontaneousWakeUpEpinephrineBoost_DisplayName">
<English>Epinephrine Increases Wake Up Chance</English>
<Japanese>アドレナリンで覚醒確率上昇</Japanese>
<Chinese>腎上腺素甦醒機率增加</Chinese>
<French>L'épinéphrine augmente les chances de réveil</French>
<Italian>L'epinefrina aumenta la possibilità di rialzarsi</Italian>
<Czech>Epinefrin zvyšuje šanci na probuzení</Czech>
<Polish>Szansa na wybudzenie po użyciu Epinefryny</Polish>
<Portuguese>Epinefrina Aumenta a chance de acordar</Portuguese>
<Spanish>Epinefrina, aumenta la posibilidad de despertar</Spanish>
<German>Epinephrin erhöht die Aufwachwahrscheinlichkeit</German>
<English>Epinephrine Wake Up Chance Boost</English>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Boosts wake up chance?

Copy link
Member Author

@jonpas jonpas Jan 5, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a string for a setting name, it's not an explanation of what it does. And it's a boost/multiplier, not a toggle.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ref https://github.com/acemod/ACE3/blob/master/addons/medical_statemachine/functions/fnc_handleStateUnconscious.sqf#L37-L42

It doesn't directly change the wake up chance,
but instead decreases the time between doing wakeup random
I did it this way because epi is somewhat short lived, so I felt like this would be the most responsive

Not positive on the math, but the effect should be similar

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, math looks good, but the setting name was confusing.

</Key>
<Key ID="STR_ACE_Medical_spontaneousWakeUpEpinephrineBoost_Description">
<English>Increases how often spontaneous wake up checks happen when patient has Epinephrine in their system.</English>
Expand Down