Medical - Fix epinephrine wake-up chance boost string #7407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thojkooi
reviewed
Jan 5, 2020
| <Czech>Epinefrin zvyšuje šanci na probuzení</Czech> | ||
| <Portuguese>Epinefrina Aumenta a chance de acordar</Portuguese> | ||
| <Spanish>Epinefrina, aumenta la posibilidad de despertar</Spanish> | ||
| <English>Epinephrine Wake Up Chance Boost</English> |
There was a problem hiding this comment.
This is a string for a setting name, it's not an explanation of what it does. And it's a boost/multiplier, not a toggle.
There was a problem hiding this comment.
It doesn't directly change the wake up chance,
but instead decreases the time between doing wakeup random
I did it this way because epi is somewhat short lived, so I felt like this would be the most responsive
Not positive on the math, but the effect should be similar
There was a problem hiding this comment.
Yeah, math looks good, but the setting name was confusing.
PabstMirror
approved these changes
Jan 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
Not sure if it's a direct multiplier due to connection with epinephrine effectiveness, so I used "boost" as is in the setting name.
Could also be improved with showing it as a percentage in the UI.