Gunbag - Add weapon swapping

[mjc4wilton]

Adds the capability to swap the currently held primary weapon and the weapon currently stored in the gunbag. Has a 1.5x (7.5 seconds) time to complete compared to just adding or removing a weapon from the gunbag without a primary for balance purposes.

When merged this pull request will:

• Allow user to swap a currently held primary and the weapon stored in the gunbag via self-interaction.
• Add addon option to enable / disable the interaction server-side (default is enabled)
• Resolve Cant switch gunbag weapon with active primary weapon #4119

[jokoho48]

this PR looks 1 to 1 like #6212 but with changed authors in headers and no keybindings.
removing someone else as author is not the gentlemen way

[commy2]

If it is the exact same thing as #6212, then this one can be closed.

[commy2]

Btw, I don't want either of them. And it is not me not liking the code, but the feature.

[jonpas]

Then don't use it. We went over this before.

[commy2]

Sure, but

jokoho48 requested your review on this pull request.

on the other one. I am not going to approve something I don't like.

[jokoho48]

In addition to the changes, I would recommend adding a keybinding.
I would also not put automatically generated translations in there and keep it open for translators todo. The current one for German is fairly bad.

[mjc4wilton]

A few points:

• I wrote this for our private unit's modpack as we occasionally run a sniper element in a QRF scenario when we organize ourselves into multiple platoons. I submitted this pull request primarily so we do not need to manually override the pbo whenever we update ACE and because IMO its a feature that should be in already.
• I did not know about Add Switching of Weapon from gunbag. #6212. If this code is identical to that one its one heck of a coincidence.
• I do not often script stuff on larger projects with multiple people. Apologies for attribution issues. Should be fixed now. I'm in no way trying to plagiarize other peoples' work because thats a low move.
• I personally do not believe this action needs a keybind. Currently there are no keybinds for the other gunbag actions as far as I am aware, I am not sure why this needs one. I feel that adding a keybind will go against a lot of the discussion about balance in issue Cant switch gunbag weapon with active primary weapon #4119, which is why I modified the time it takes for this action to be 1.5x that of just removing / adding a weapon without another primary.
• Apologies for horrendous translations. I can easily remove them and just leave English if that is preferred.

[mjc4wilton]

I just updated the Stringtable. I went around my unit and found people to translate to most languages. German, French, Russian, and Czech have all been translated by natives of their respective languages. I then went through the remaining Japanese, Polish, Korean, Italian, Chinese (Simplified), and Chinese and used online translators back on fourth to get them as close as I could. I've cross checked them all back to English in as many translators as I could find and I believe they are correct.

[mjc4wilton]

Everything tested in-game up to this point

[mjc4wilton]

Everything has been tested and works in-game up to this point

[jokoho48]

LGTM except for the small optimisation

[PabstMirror]

looks good overall

[PabstMirror]

minor changes