Explosives - Fix Dial Tone Sound Position #8488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PabstMirror
approved these changes
Oct 7, 2021
PabstMirror
reviewed
Oct 7, 2021
LinkIsGrim
reviewed
Oct 7, 2021
|
I guess we could also get rid of the |
AndreasBrostrom
pushed a commit
to AndreasBrostrom/ACE3
that referenced
this pull request
Dec 3, 2021
* explosives - fix dial tone sound position * Use right hand pos instead of hardcoded pos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
modelToWorldVisualwithmodelToWorldVisualWorldso thatplaySound3Dplays the dial sound at the correct position.I wanted to implement dialing as requested here, but to my surprise there was already dial tone functionality in the module!
A quick search shows every other code that uses
playSound3DwithmodelToWorldVisualfirst runs it throughAGLToASL, so this bug was unique. Edit: I've made another PR (#8489) to get rid of this ambiguity everywhere else.