Use modelToWorldVisualWorld #8489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PabstMirror
added
kind/cleanup
PabstMirror
reviewed
Oct 9, 2021
| @@ -28,16 +28,16 @@ private _gunEnd = getText (_turret >> "gunEnd"); | |||
| TRACE_3("", _pov, _gunBeg, _gunEnd); | |||
|
|
|||
| // Pull the PIP pov or barrel direction, depending on how the model is set up | |||
| private _povPos = ATLtoASL (_vehicle modelToWorldVisual (_vehicle selectionPosition _pov)); //@todo AGLToASL ? | |||
There was a problem hiding this comment.
old func: boat on the water it gave turret postASL as [1574.31,3870.15,-14.5889]
so great fix, but doesn't look like anything uses this func
There was a problem hiding this comment.
Looks like CBA also has a much more intricate turretDir; though that is not used anywhere in ACE3 either.
PabstMirror
approved these changes
Oct 9, 2021
jonpas
approved these changes
Oct 10, 2021
AndreasBrostrom
pushed a commit
to AndreasBrostrom/ACE3
that referenced
this pull request
Dec 3, 2021
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
AGLtoASL + modelToWorldVisualcombinations with justmodelToWorldVisualWorldto get an ASL position.Clean-up after my discovery in #8488