Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common - Add keybind and function to unload unit's weapon/muzzle #8735

Merged
merged 7 commits into from
May 18, 2022

Conversation

Drofseh
Copy link
Contributor

@Drofseh Drofseh commented Dec 11, 2021

When merged this pull request will:

To Do:

  • document new weapon config entries, ACE_unloadAction, ACE_unloadSound. I'm not sure which framework doc to put this in.
  • see if there's a way to interupt the reload animation if there is no ACE_unloadAction

@Drofseh
Copy link
Contributor Author

Drofseh commented Dec 18, 2021

I haven't been able to find a way to interupt the default reload animation, playing another gesture (or no gesture) doesn't seem to do it.
However, even when the full reload animation is played, because the magazine disappears in the middle it looks like they are just clearing the chamber, so I'm happy with it as is.

@Drofseh Drofseh marked this pull request as ready for review December 18, 2021 23:48
@jonpas jonpas changed the title Common - add keybind and function to unload unit's weapon/muzzle Common - Add keybind and function to unload unit's weapon/muzzle Dec 19, 2021
@Drofseh
Copy link
Contributor Author

Drofseh commented Mar 20, 2022

This is ready for review now that CBATeam/CBA_A3#1527 has been merged

@PabstMirror PabstMirror added this to the 3.14.2 milestone May 17, 2022
@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label May 17, 2022
@PabstMirror
Copy link
Contributor

I can mash the button and multiple sound effects play
but it doesn't dupe ammo so it's probably not a problem

@PabstMirror
Copy link
Contributor

also maybe this should be in ace_reload?

Co-authored-by: PabstMirror <pabstmirror@gmail.com>
@jonpas
Copy link
Member

jonpas commented May 18, 2022

I think I recommended common as I saw potential uses for it in other modules.

@PabstMirror PabstMirror merged commit 86f08af into acemod:master May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants