[NDB_Factory] Remove testing mode #7199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "Testing" mode in NDB_Factory complicates our code and frequently confuses phan. It appears to not be used by our testing suite, and the test suite often explicitly sets it to not-test mode in order to get real connections, and uses setDatabase/setConfig/etc to inject mocks rather than using the factory's internal test mode. This removes the mode and simplifies our code.
driusan
added
the
Needs Work
driusan
added
the
"Help! I don't understand Travis!"
|
@driusan This commit should be helpful. |
driusan
force-pushed
the
RemoveFactoryTestingMode
branch
from
19608db
to
3bf3057
Compare
driusan
force-pushed
the
RemoveFactoryTestingMode
branch
from
6bd673c
to
81deef5
Compare
driusan
removed
"Help! I don't understand Travis!"
driusan
added
Cleanup
|
@kongtiaowang Now that this is passing Travis can you review? It's blocking something else that I was trying to do that I couldn't get phan to pass because of the (previous) convoluted return types in different paths. |
|
@kongtiaowang can you please review this now that it's passing Travis. It's blocking other work. |
|
@kongtiaowang This is still preventing important work on LORIS from going forward. Please review. |
kongtiaowang
approved these changes
Jan 7, 2021
AlexandraLivadas
pushed a commit
to AlexandraLivadas/Loris
that referenced
this pull request
Jun 29, 2021
The "Testing" mode in NDB_Factory complicates our code and frequently confuses phan. It appears to not be used by our testing suite, and the test suite often explicitly sets it to not-test mode in order to get real connections, and uses setDatabase/setConfig/etc to inject mocks rather than using the factory's internal test mode. This removes the mode and simplifies our code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Testing" mode in NDB_Factory complicates our code
and frequently confuses phan. It appears to not be used
by our testing suite, and the test suite often explicitly
sets it to not-test mode in order to get real connections,
and uses setDatabase/setConfig/etc to inject mocks rather
than using the factory's internal test mode. This removes
the mode in order to simplify our code.