Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NDB_Factory] Remove testing mode #7199

Merged
merged 23 commits into from
Jan 7, 2021
Merged

[NDB_Factory] Remove testing mode #7199

merged 23 commits into from
Jan 7, 2021

Commits on Dec 14, 2020

  1. [NDB_Factory] Remove testing mode 

    The "Testing" mode in NDB_Factory complicates our code
and frequently confuses phan. It appears to not be used
by our testing suite, and the test suite often explicitly
sets it to not-test mode in order to get real connections,
and uses setDatabase/setConfig/etc to inject mocks rather
than using the factory's internal test mode. This removes
the mode and simplifies our code.
    @driusan
    driusan committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    c49ffbb View commit details
    Browse the repository at this point in the history

  2. PHPCS

    @driusan
    driusan committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    4e36246 View commit details
    Browse the repository at this point in the history

  3. Remove calls to setTesting

    @driusan
    driusan committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    59e196f View commit details
    Browse the repository at this point in the history

  4. Do not suppress phan

    @driusan
    driusan committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    e788ad4 View commit details
    Browse the repository at this point in the history

  5. More setTesting calls

    @driusan
    driusan committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    ea5c90e View commit details
    Browse the repository at this point in the history

  6. phpcs

    @driusan
    driusan committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    596c6b7 View commit details
    Browse the repository at this point in the history

  7. one more settesting

    @driusan
    driusan committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    872ae41 View commit details
    Browse the repository at this point in the history

  8. Add some missing sets

    @driusan
    driusan committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    ab9b301 View commit details
    Browse the repository at this point in the history

  9. Missing config in database test

    @driusan
    driusan committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    6d8086a View commit details
    Browse the repository at this point in the history

  10. missing configs

    @driusan
    driusan committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    141628b View commit details
    Browse the repository at this point in the history

  11. More setters

    @driusan
    driusan committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    0170f11 View commit details
    Browse the repository at this point in the history

  12. And another

    @driusan
    driusan committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    a0ce835 View commit details
    Browse the repository at this point in the history

  13. Set factory in integration tests

    @driusan
    driusan committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    86e02aa View commit details
    Browse the repository at this point in the history

  14. Set the factory in NDB_Client

    @driusan
    driusan committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    e660731 View commit details
    Browse the repository at this point in the history

  15. Explicitly set database in NDB_Client

    @driusan
    driusan committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    0a124cd View commit details
    Browse the repository at this point in the history

  16. phpcs

    @driusan
    driusan committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    6959d7b View commit details
    Browse the repository at this point in the history

  17. Typo

    @driusan
    driusan committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    d8117df View commit details
    Browse the repository at this point in the history

  18. More sets

    @driusan
    driusan committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    9fd7b0d View commit details
    Browse the repository at this point in the history

  19. Test

    @driusan
    driusan committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    aae2395 View commit details
    Browse the repository at this point in the history

  20. Use same structure as Database tests

    @driusan
    driusan committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    3fda1ce View commit details
    Browse the repository at this point in the history

  21. typo

    @driusan
    driusan committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    265ed8c View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2020

  1. Use mocks for failing tests

    @driusan
    driusan committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    3bf3057 View commit details
    Browse the repository at this point in the history

  2. Do not depend on RB for utility test

    @driusan
    driusan committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    81deef5 View commit details
    Browse the repository at this point in the history