-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[electrophysiology_browser] Replace Physiological Annotations with Events #9032
[electrophysiology_browser] Replace Physiological Annotations with Events #9032
Conversation
@regisoc can you review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
- global logic looks good. Some questions for the back-end class.
- Still some TODOs in the code. I avoided repeating all comments. The comment on the first one should be valid for all similar following it.
- rename permission
electrophysiology_browser_edit_annotations
toelectrophysiology_browser_edit_events
? - Some cleaning to do (commented lines to remove/keep)?
- Not tested yet. I might need help setting up testing env.
modules/electrophysiology_browser/php/models/electrophysioevents.class.inc
Show resolved
Hide resolved
...ctrophysiology_browser/jsx/react-series-data-viewer/src/series/components/AnnotationForm.tsx
Outdated
Show resolved
Hide resolved
...ctrophysiology_browser/jsx/react-series-data-viewer/src/series/components/AnnotationForm.tsx
Outdated
Show resolved
Hide resolved
...ctrophysiology_browser/jsx/react-series-data-viewer/src/series/components/AnnotationForm.tsx
Outdated
Show resolved
Hide resolved
...ctrophysiology_browser/jsx/react-series-data-viewer/src/series/components/SeriesRenderer.tsx
Outdated
Show resolved
Hide resolved
I will put that here so we do not forget them. Note after tests:
|
@jeffersoncasimir let me know if you need another round of test this morning. |
This reverts commit 46e6dce.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New pass:
- error on
epoch
resolved. - new errors due to multiple config db calls that can vary from config.xml. Unify calls for config check to
$config->getSetting("dataDirBasepath");
in electrophysiologyevents.class.inc (one in_updateArchives
one inupdate
). Archive events fileNot corrupted, but not a gzip archive? Usingtgz
created and downloadable, but archive is corrupted.tar xf <file>
works, but not when usingtar xzf <file>
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR aims to improve the current compliance to the BIDS standard. Loris-MRI counterpart: #1041
Partially addresses #8910.
This replaces references to
annotation
files with references toevent
files.This PR deletes
*_annotation_*
tables. The corresponding required event tables already exist.+minor improvements to the
EventManager
andAnnotationForm
components.This PR brings in the following limitations:
read-only
ordisabled
(Name and time)TODO: Raisinbread modificationsTODO: Get official server-side solution + Add to documentation.
Both of the above needed to be increased for certain requests.