Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EEG] HED Tag Support #8910

Closed
jeffersoncasimir opened this issue Oct 3, 2023 · 1 comment · Fixed by #9033
Closed

[EEG] HED Tag Support #8910

jeffersoncasimir opened this issue Oct 3, 2023 · 1 comment · Fixed by #9033
Assignees
@jeffersoncasimir
Labels
Feature PR or issue introducing/requiring at least one new feature

Comments

@jeffersoncasimir
Copy link
Contributor

jeffersoncasimir commented Oct 3, 2023 •
edited
Loading

HED tag support, which is present in EEGNet, can be brought in to LORIS. This adds the ability to add and remove HED tags from event instances and attribute mappings (events.json).

This includes SQL patches and significant Loris-MRI changes.

This also includes the removal of "Annotations" in favour for "Events", in order to keep up with the latest BIDS specifications, and a CouchDB import.
@jeffersoncasimir jeffersoncasimir added the Feature PR or issue introducing/requiring at least one new feature label Oct 3, 2023
@jeffersoncasimir jeffersoncasimir added this to the 26.0.0 milestone Oct 3, 2023
@ridz1208 ridz1208 moved this to Assigned in LORIS RoadMap Oct 10, 2023
@christinerogers
Copy link
Contributor

christinerogers commented Oct 10, 2023 •
edited
Loading

Per Loris meeting just now (and Loris-EEG meeting last week) --
@jeffersoncasimir will push this to LORIS if possible in 2023, time permitting.
@laemtl can review and test.

@jeffersoncasimir jeffersoncasimir removed this from the 26.0.0 milestone Nov 14, 2023
This was referenced Feb 1, 2024
Merged
Merged
driusan pushed a commit that referenced this issue Feb 27, 2024
@jeffersoncasimir
[electrophysiology_browser] Replace Physiological Annotations with Ev…
1112e1a 
…ents (#9032)

This aims to improve the current compliance to the BIDS standard. Loris-MRI counterpart: #1041
Partially addresses #8910.

This replaces references to annotation files with references to event files.

This deletes *_annotation_* tables. The corresponding required event tables already exist.

+minor improvements to the EventManager and AnnotationForm components.
driusan pushed a commit that referenced this issue Mar 19, 2024
@jeffersoncasimir
[electrophysiology_browser] HED Tag Support (#9033)
659cc70 
This adds more robust HED tag support. Closes #8910.

It adds SQL tables to store HED schemas as hierarchical nodes and to store the assembled HED strings as node references using a modified linked list data structure, allowing for complex groupings.

Instance-level tags which were ingested in the HED column of events.tsv files can be viewed in the EventManager component and can be edited in a limited (see below) way in the AnnotationForm component.

There is a new component called DatasetTagger which is accessible via the "Dataset Tag Manager" button at the bottom left corner of the browser. This component enables the modification of HED tags at the dataset-wide level (events.json). This will associate HED tags to Event attributes for all events in the dataset containing the respective attributes. This component enables virtually unlimited groupings of HED tags, as well their addition and removal.

Limitations:

    "Value" HED tags are not supported
    "Expanded Definitions" are not supported
    Editing the "Level description" via the "Dataset Tag Manager" is not currently supported (coming soon)
    Session-level events.json overriding and assignment not currently supported.
    Adding HED tags on an event level is currently limited to: SCORE artifacts (if SCORE schema ingested) and tags that were previously added via the ingestion of the events.json or manually via the Dataset Tag Manager.

Related: Loris-MRI/#1041
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeffersoncasimir jeffersoncasimir

Labels
Feature PR or issue introducing/requiring at least one new feature
Projects
LORIS RoadMap
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[electrophysiology_browser] HED Tag Support jeffersoncasimir/Loris
3 participants
@christinerogers @jeffersoncasimir @laemtl