Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript definitions #3

Closed
AuHau opened this issue Sep 8, 2020 · 1 comment · Fixed by #7
Closed

Typescript definitions #3

AuHau opened this issue Sep 8, 2020 · 1 comment · Fixed by #7

Comments

@AuHau
Copy link

AuHau commented Sep 8, 2020

Would welcome to have types definitions for your utilities to be used in TS.
Happy to make PR for it.
@achingbrain
Copy link
Owner

Please do submit a PR, I'll gladly merge it.

@AuHau AuHau mentioned this issue Sep 9, 2020
Closed
@wemeetagain wemeetagain mentioned this issue Dec 12, 2020
Merged
1 task
achingbrain pushed a commit that referenced this issue Dec 18, 2020
@wemeetagain
feat: aegir types generation (#7)
0fa0604 
Minimal updates to add autogenerated typescript types via aegir.
Used this doc to help: https://github.com/ipfs/aegir/blob/master/md/ts-jsdoc.md

I tested this PR locally, linking this to a test project (including updated `web-encoding` dependency) to make sure the types all line up.

See #4 (comment)
Resolves #3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: aegir types generation ChainSafe/uint8arrays
feat: ts definitions AuHau/uint8arrays
2 participants
@achingbrain @AuHau