Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: aegir types generation #7

Merged
merged 2 commits into from
Dec 18, 2020
Merged

feat: aegir types generation #7

merged 2 commits into from
Dec 18, 2020

Conversation

wemeetagain
Copy link
Contributor

@wemeetagain wemeetagain commented Dec 12, 2020 •
edited
Loading

Minimal updates to add autogenerated typescript types via aegir.
Used this doc to help: https://github.com/ipfs/aegir/blob/master/md/ts-jsdoc.md

I tested this PR locally, linking this to a test project (including updated web-encoding dependency) to make sure the types all line up.

See #4 (comment)
Resolves #3

Prerequisite:

@wemeetagain
Copy link
Contributor Author

ready for review @achingbrain

@achingbrain
Copy link
Owner

Awesome stuff, thanks!

@achingbrain achingbrain changed the title Aegir types generation feat: aegir types generation Dec 18, 2020
@achingbrain achingbrain merged commit 0fa0604 into achingbrain:master Dec 18, 2020
@achingbrain achingbrain mentioned this pull request Dec 18, 2020
Closed
@wemeetagain wemeetagain deleted the feat/types branch December 18, 2020 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typescript definitions
2 participants
@wemeetagain @achingbrain