Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Changes log #12

Merged
merged 1 commit into from
Feb 1, 2017
Merged

Add Changes log #12

merged 1 commit into from
Feb 1, 2017

Conversation

lmignon
Copy link
Member

@lmignon lmignon commented Feb 1, 2017

No description provided.

yajo
yajo approved these changes Feb 1, 2017
View reviewed changes
Copy link
Contributor

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eager to use the new release!

README.rst Outdated
* Use setuptools_scm for the release process (https://github.com/acsone/git-aggregator/pull/10)
* Expand env vars in config. (https://github.com/acsone/git-aggregator/pull/8)
* Fetch only required remotes. (https://github.com/acsone/git-aggregator/pull/6)
* Display readable error if config file not found. (https://github.com/acsone/git-aggregator/pull/2)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot about --depth (#7) 😊

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yajo Good catch. added.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.803% when pulling b75ca25 on add_change_log into 7ecfdbe on master.

4 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.803% when pulling b75ca25 on add_change_log into 7ecfdbe on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.803% when pulling b75ca25 on add_change_log into 7ecfdbe on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.803% when pulling b75ca25 on add_change_log into 7ecfdbe on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.803% when pulling b75ca25 on add_change_log into 7ecfdbe on master.

@coveralls
Copy link

coveralls commented Feb 1, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 89.803% when pulling 5e51a2f on add_change_log into 7ecfdbe on master.

@coveralls
Copy link

coveralls commented Feb 1, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 89.803% when pulling 4f296ec on add_change_log into 7ecfdbe on master.

@sbidoul
Copy link
Member

sbidoul commented Feb 1, 2017

@lmignon can you add a line to DEVELOP.rst to remind to update the changelog when releasing.

@coveralls
Copy link

coveralls commented Feb 1, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 89.803% when pulling c17511c on add_change_log into c564c60 on master.

@lmignon
Copy link
Member Author

lmignon commented Feb 1, 2017

@sbidoul done

@sbidoul sbidoul merged commit aefc25c into master Feb 1, 2017
@sbidoul sbidoul deleted the add_change_log branch February 1, 2017 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yajo yajo yajo approved these changes

Assignees

@sbidoul sbidoul

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lmignon @coveralls @sbidoul @yajo