Master depth #7
Merged
Master depth #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbidoul
reviewed
Jan 3, 2017
| @@ -20,17 +19,24 @@ def _parse_config(self, config_str): | |||
| return conf.export('dict') | |||
|
|
|||
| def test_load(self): | |||
| config_yaml = """ | |||
There was a problem hiding this comment.
@yajo could you preserve the existing test untouched so we can have confidence the change preserves backward compatibility
|
Got it! WIP no more, please review 😊 |
lmignon
reviewed
Jan 3, 2017
| @@ -22,6 +22,7 @@ install: | |||
|
|
|||
| # command to run tests | |||
| script: | |||
| - git --version | |||
There was a problem hiding this comment.
@yajo Is this line still required?
There was a problem hiding this comment.
Well, there was a problem with Travis' git version: it fails with git pull --depth 2 --no-edit remote ref, but works with git pull --no-edit --depth 2 remote ref. I had to add the line to see if that was the bug because local tests worked.
I guess it's good to keep that line as reference, just in case for future Travis vs localhost git version conflicts.
|
Yes, of course, you have to know what you are doing, but if you do... 🚀 |
yajo
added a commit
to Tecnativa/doodba
that referenced
this pull request
Jan 24, 2017
Now acsone/git-aggregator#6 and acsone/git-aggregator#7 are merged. However, we still have to use a development version, so we hash-pin it.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be WIP until bots go ✔️ and you merge:
Adds support for shallow git repositories.
@Tecnativa