Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs review #214

Closed
wants to merge 185 commits into from
Closed

Docs review #214

wants to merge 185 commits into from

Conversation

mmacata
Copy link
Member

@mmacata mmacata commented May 28, 2021

This PR is not meant to be merged but only to add review comments to docs folder.
For this, this instruction was followed https://astrofrog.github.io/blog/2013/04/10/how-to-conduct-a-full-code-review-on-github/ but with commit hash before docs transformation from rst to docs, to not show all code here.

Happy review + commenting!

neteler and others added 4 commits May 27, 2021 11:49
* tutorial: added MD files converted from rst
* update .gitignore for mkdocs
* cleanup old rst and related
* Makefile added
* rename resources folder folder to rest + use absolute imports

* lint

* recover ephemeral_processing.py
* initial commit

* add new endpoint and response to list all locked mapsets

* add swagger doc

* remove debugger

* correct response model

* clean up importing

* review CT

* fetch original mapset_management.py

* update swagger

* break line for if-linting

* add test

* update paths

* CT review 2

* add class setup method

* simplify test

Co-authored-by: Guido Riembauer <riembauer@mundialis.de>
* set maintainer to mundialis

* splitup geodata_download_impoerter and start utils

* splitup google_satellite_bigquery_interface.py

Co-authored-by: anikaweinmann <aweinmann@mundialis.de>
@mmacata mmacata requested a review from juleshaas May 28, 2021 09:45
Copy link
Member

@juleshaas juleshaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issues in actinia_core/docs/docs/actinia_concepts.md

docs/docs/actinia_concepts.md Show resolved Hide resolved
docs/docs/actinia_concepts.md Show resolved Hide resolved
docs/docs/actinia_concepts.md Show resolved Hide resolved
* move response models to models folder

* move models out of api_log_management

* move models, imports + lint

* move mapset + process_chain models

* move more models
juleshaas and others added 15 commits May 28, 2021 14:04
* update local testing in readme

* remove resources/common

* update docker readme and tests readme

* delete old response_models.py

* Update docker/README.md

Co-authored-by: Markus Neteler <neteler@gmail.com>

* Apply suggestions from code review MN

Co-authored-by: Markus Neteler <neteler@gmail.com>

Co-authored-by: Markus Neteler <neteler@gmail.com>
* update folder structure
* update docker readme

* add hint to docker readme
* gource script, fixes #206
* gource: add README.md and caption file
* script cosmetics
Co-authored-by: anikaweinmann <aweinmann@mundialis.de>
* local GeoTIFF import

* swagger doc

* remove file by error + linting

* fix tests

* CT review

* flake8

* fix

Co-authored-by: anikaweinmann <aweinmann@mundialis.de>
* move modules used by plugins

* move shared modules to common folder
update paths in scripts: core/common folder
@mmacata mmacata marked this pull request as draft August 4, 2021 14:18
ashiklom and others added 5 commits August 4, 2021 16:22
The `/api/v1` is required -- otherwise, you get a cryptic "404 Not Found" HTML error.
* init docker gh action

* debug gha

* ...

* update gha

* remove test branch
* cleaning documentation, removing minor mistakes

* remove empty line in table

* minor changes

* minor changes

* little adjustments and additions to tutorials

* adaptions in tutorials

* format overview table
* add openeo addons

* Update grass_addons_list.csv
* first successful test

* fixes for debugging

* cleanup merge

* linting and adapeted authors

* test

* fix tgis if mapsets with tgis folder already exists

* linting and tests

* GR mini review

Co-authored-by: anikaweinmann <aweinmann@mundialis.de>
Co-authored-by: Guido Riembauer <riembauer@mundialis.de>
anikaweinmann and others added 24 commits May 25, 2022 12:52
* start test

* pc with new parameters

* test for resampling and resolution in importer

* add mangkawuk dataset to actinia test datasets, add tests for requests resulting in error
* update dependency README

* update dependency README

* add option for separate queue per job

* lint

* Apply suggestions from code review

Co-authored-by: Markus Metz <33666869+metzm@users.noreply.github.com>

* Update redis_queue.md

Co-authored-by: Markus Metz <33666869+metzm@users.noreply.github.com>

* Update src/actinia_core/core/common/config.py

Co-authored-by: Markus Metz <33666869+metzm@users.noreply.github.com>
* Endpoint configuration

Co-authored-by: anikaweinmann <aweinmann@mundialis.de>
Co-authored-by: Carmen Tawalika <mmacata@users.noreply.github.com>
Co-authored-by: Marc Jansen <jansen@terrestris.de>
Co-authored-by: anikaweinmann <aweinmann@mundialis.de>
* always use local queue for sync requests

* add required argument

* control queue type overwrite via config
docs: replace broken api docs links
@juleshaas
Copy link
Member

All comments have been resolved or moved to individual issues. This PR will be closed.

@juleshaas juleshaas closed this Jul 29, 2022
@mmacata mmacata added this to the not_released milestone Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.